Issue1017

Title GitHub Actions fail for repos that are not called "downward"
Priority bug Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2021-03-24.10:00:55 by jendrik, last changed by jendrik.

Messages
msg10262 (view) Author: jendrik Date: 2021-04-29.19:41:56
Silvan green-lit the change on GitHub so I went ahead and merged it. Thanks for the review! BTW: I tested the change with and without the LP solver secrets.
msg10261 (view) Author: silvan Date: 2021-04-29.18:18:26
I had a look and left some comments.
msg10253 (view) Author: jendrik Date: 2021-04-29.00:08:18
I made a pull request at https://github.com/aibasel/downward/pull/38 . Silvan, can you have a look, please?
msg10236 (view) Author: malte Date: 2021-03-24.17:42:22
Makes sense to me. My understanding is that the actions run in their own VM. No need to use the repository name for disambiguation/providing a separate namespace then.
msg10233 (view) Author: silvan Date: 2021-03-24.10:03:33
I would suggest to use /home/runner as the base path for everything. Then we can have the repository clone there, using a fixed name independent of the repo, and also a lib dir where we install the LP-related libraries.
msg10232 (view) Author: jendrik Date: 2021-03-24.10:00:55
The GitHub Actions run in the directory /home/runner/work/<reponame>. As one of the first steps, they clone the repo to /home/runner/work/<reponame>/<reponame>. Since the "Install dependencies" step calls "mkdir /home/runner/work/downward/lib", the step fails for all repos that are not called "downward".

When testing the fix for this issue, I think it would be good to test it both with and without the CPLEX and/or SoPlex secret set.
History
Date User Action Args
2021-04-29 19:41:59jendriksetstatus: reviewing -> resolved
messages: + msg10262
2021-04-29 18:18:27silvansetmessages: + msg10261
2021-04-29 00:08:19jendriksetstatus: chatting -> reviewing
messages: + msg10253
2021-04-28 23:16:10jendriksetassignedto: jendrik
2021-03-24 17:42:22maltesetmessages: + msg10236
2021-03-24 10:03:34silvansetstatus: unread -> chatting
nosy: + silvan
messages: + msg10233
2021-03-24 10:00:55jendrikcreate