Issue1182

Title use std::make_unique instead of utils::make_unique_ptr
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2025-03-11.14:17:03 by jendrik, last changed by jendrik.

Messages
msg11823 (view) Author: jendrik Date: 2025-03-11.16:10:01
Thanks! Merged.
msg11822 (view) Author: florian Date: 2025-03-11.14:27:47
Looks good to me. The only comment I have is that in most places we now no longer include <memory>. It is probably implicitly included everywhere, so I'm not sure if we need the explicit include. IWYU would suggest that we do but we don't follow it that strictly.
msg11821 (view) Author: jendrik Date: 2025-03-11.14:17:03
Now that we require C++20, we can get rid of our own std::make_unique implementation. I prepared a pull request for this here: https://github.com/aibasel/downward/pull/257 Can someone review it, please?
History
Date User Action Args
2025-03-11 16:10:01jendriksetstatus: reviewing -> resolved
messages: + msg11823
2025-03-11 14:27:47floriansetnosy: + florian
messages: + msg11822
2025-03-11 14:17:03jendrikcreate