Issue1231

Title Remove continue_on_fail option in iterated search
Priority wish Status chatting
Superseder Nosy List Claudia, gabi, jendrik, malte, simon
Assigned To Keywords
Optional summary

Created on 2026-07-24.14:58:29 by simon, last changed by Claudia.

Messages
msg12126 (view) Author: Claudia Date: 2026-07-28.17:23:34
After merging the PR for issue1201 we now have a PR for this story in aibasel/downward:
https://github.com/aibasel/downward/pull/302
msg12117 (view) Author: simon Date: 2026-07-25.20:55:22
draft PR
https://github.com/grucla/downward/pull/1
msg12116 (view) Author: simon Date: 2026-07-24.14:58:29
In one of the commits of issue1201 this was added:
"""
bool IteratedSearch::is_complete_within_bound() const {
    /*
      TODO
      - return true if the first search algorithm is complete and its bound is
        greater or equal to that of IteratedSearch, i.e. if it is complete
        within the bound of IteratedSearch
      - otherwise (the first search algorithm is not complete within
        IteratedSearch's bound), return false if continue_on_fail == false
      - otherwise (continue_on_fail == true and first search algorithm is not
        complete within IteratedSearch's bound), return true if at least one
        (other) search algorithm is complete within IteratedSearch's bound
      - otherwise (continue_on_fail == true and all search algorithms are not
        complete within IteratedSearch's bound), return false

      Before we solve the component interaction problem (issue559), we cannot
      access the necessary information from within a constant function.

      Once we can implement this function we also want to change IteratedSearch
      such it automatically stops once a complete search finds no solution.
      In that case the continue_on_fail option would not really be useful
      anymore and should be removed. (Result of discussion between Claudia,
      Malte, and Gabi.)
    */
    log << "Warning: the completeness check for IteratedSearch is not yet implemented."
        << endl;
    return false;
}
"""

To reduce the size of the change from issue1201 this issue is about taking care of the last paragraph of the comment.
History
Date User Action Args
2026-07-28 17:23:34Claudiasetmessages: + msg12126
2026-07-25 20:55:22simonsetmessages: + msg12117
2026-07-24 14:58:29simoncreate