Issue269

Title Use new RNG everywhere
Priority wish Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2011-08-27.15:52:05 by malte, last changed by malte.

Messages
msg3979 (view) Author: malte Date: 2014-12-20.12:05:34
Great! :-)
msg3978 (view) Author: jendrik Date: 2014-12-20.12:03:56
Merged and pushed.
msg3977 (view) Author: malte Date: 2014-12-19.22:06:38
OK, feel free to merge if you like.
msg3976 (view) Author: jendrik Date: 2014-12-19.22:03:57
Well, we had to expect that there would be cases where the algorithms perform 
better and cases where they perform worse. The only notable change I see is 
that the original M&S mas-buckets config solves 3 tasks in barman, whereas it 
solves no task with the new RNG. I looked into the logs and it seems that the 
reason is that with the new "shrink order" there's not enough memory to merge 
all variables. I don't know if we can or should do anything about this.
msg3974 (view) Author: malte Date: 2014-12-19.19:16:31
Thanks! What do you make of the data?
msg3973 (view) Author: jendrik Date: 2014-12-19.18:56:41
As suggested I ran two experiments, here are the results:

http://ai.cs.unibas.ch/_tmp_files/seipp/issue269-opt-issue269-base-issue269-v1-
compare.html
http://ai.cs.unibas.ch/_tmp_files/seipp/issue269-sat-issue269-base-issue269-v1-
compare.html
msg3923 (view) Author: malte Date: 2014-12-13.13:38:30
So, I did add some more comments after all, but now I'm done.
msg3922 (view) Author: malte Date: 2014-12-13.13:07:39
To clarify, what I meant was: it would be good to address the comment about
shuffling in particular first because it might affect the interface of g_rng
(which would need to become compatible with the standard library's URNGs). This
is a large enough change that I think it would be good to rereview afterwards,
so I'd rather review the rest of the changes then rather than doing it twice.
msg3921 (view) Author: malte Date: 2014-12-13.13:02:33
I've made two initial comments and would suggest rereviewing later.
msg3920 (view) Author: jendrik Date: 2014-12-13.11:45:15
I made a pull request at bitbucket. Can you have a look at the code, please?
msg1695 (view) Author: malte Date: 2011-08-27.15:52:04
The new RNG should be used everywhere. Search for srand, rand, random_shuffle.
History
Date User Action Args
2014-12-20 12:05:34maltesetmessages: + msg3979
2014-12-20 12:03:56jendriksetstatus: testing -> resolved
messages: + msg3978
2014-12-19 22:06:38maltesetmessages: + msg3977
2014-12-19 22:03:57jendriksetmessages: + msg3976
2014-12-19 19:16:31maltesetmessages: + msg3974
2014-12-19 18:56:41jendriksetstatus: reviewing -> testing
messages: + msg3973
2014-12-13 13:38:30maltesetmessages: + msg3923
2014-12-13 13:07:39maltesetmessages: + msg3922
2014-12-13 13:02:33maltesetmessages: + msg3921
2014-12-13 11:45:15jendriksetstatus: chatting -> reviewing
assignedto: jendrik
messages: + msg3920
2014-12-12 10:41:40jendriksetnosy: + jendrik
2011-08-27 15:52:05maltecreate