Issue576

Title use transition normal form for admissible potential heuristics
Priority wish Status chatting
Superseder Nosy List florian, jendrik, malte
Assigned To Keywords
Optional summary

Created on 2015-10-01.17:36:01 by jendrik, last changed by florian.

Messages
msg10214 (view) Author: florian Date: 2021-03-19.17:27:01
I still think an explicit TNF task would be useful. But I don't think it makes sense to work on this before the change to the component interaction problem is done.
msg10182 (view) Author: jendrik Date: 2021-03-18.14:11:58
I currently have no plans to pursue this. Florian, how do you feel about this? Should we close this issue (we can always reopen it if our plans change)?
msg5950 (view) Author: jendrik Date: 2016-12-20.22:20:35
Introducing the ExplicitTask class is issue700.
msg5928 (view) Author: florian Date: 2016-12-20.14:26:32
As we discussed offline, I suggest we split this issue into two or three parts: 
1) introducing the class ExplicitTask
2) introducing the class TransitionNormalFormTask
3) using TNF for potential heuristics

This should make it easier to discuss and make the dependencies more explicit.
msg5660 (view) Author: jendrik Date: 2016-09-23.19:58:26
Now that we've decided to remove GlobalOperator, we can move ahead on this issue. 
I have merged it with the latest master revision and updated it to reflect our 
latest guidelines. Florian, could you have a look at the code, please?
msg5580 (view) Author: florian Date: 2016-08-23.16:59:25
I'll have another look after the next Fast Downward meeting, where we wanted to 
discuss the classes ExplicitOperator and GlobalOperator.
msg5564 (view) Author: jendrik Date: 2016-08-16.23:19:39
Thanks for the comments. I think I took care of them all. Do you want to have 
another look, Florian?
msg5543 (view) Author: jendrik Date: 2016-08-11.00:32:44
I'm done with my changes. You can have a look at the code now.
msg5542 (view) Author: jendrik Date: 2016-08-10.23:57:49
We currently check that parent tasks of DomainAbstractedTask don't have axioms 
and conditional effects by calling the local "static bool 
has_conditional_effects(const AbstractTask &task)" function, i.e., on the level 
of AbstractTask. In this pull request, we check the same thing for 
TransitionNormalFormTask by using 

TaskProxy parent_task_proxy(*parent);
verify_no_axioms(parent_task_proxy);
verify_no_conditional_effects(parent_task_proxy);

i.e., on the level of TaskProxy. For TNFTask this is possible since the TNFTask 
is hidden in the .cc file and it is the TNFTask factory that makes the check.

We should probably discuss offline if we can use a similar approach for 
DomainAbstractedTask.
msg5540 (view) Author: jendrik Date: 2016-08-10.23:03:35
I'll try to implement the necessary methods now.
msg5539 (view) Author: florian Date: 2016-08-10.22:18:55
There still is a TODO about merging issue660. Should I wait for that?
msg5533 (view) Author: jendrik Date: 2016-08-10.17:50:38
Done with the next round of comments. Florian, could you have a look, please?
msg5463 (view) Author: jendrik Date: 2016-06-27.11:16:12
I made the changes and the pull request is ready for review again.
msg5430 (view) Author: florian Date: 2016-06-07.17:14:37
I added some comments. Can you ping me again, once you made the change to
explicit task we discussed?
msg5426 (view) Author: jendrik Date: 2016-06-06.17:17:57
I have made a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/52

Florian, can you have a look when time allows?
msg4632 (view) Author: jendrik Date: 2015-10-01.17:36:01
We'd like to use TNF for computing the admissibility constraints for potential 
heuristics.
History
Date User Action Args
2021-03-19 17:27:01floriansetmessages: + msg10214
2021-03-18 14:11:58jendriksetstatus: deferred -> chatting
messages: + msg10182
2017-05-07 18:05:12jendriksetassignedto: jendrik ->
2016-12-20 22:20:35jendriksetstatus: reviewing -> deferred
messages: + msg5950
2016-12-20 14:26:32floriansetmessages: + msg5928
2016-09-23 19:58:26jendriksetmessages: + msg5660
2016-08-23 16:59:25floriansetmessages: + msg5580
2016-08-16 23:19:39jendriksetmessages: + msg5564
2016-08-11 00:32:44jendriksetmessages: + msg5543
2016-08-10 23:57:49jendriksetmessages: + msg5542
2016-08-10 23:03:35jendriksetmessages: + msg5540
2016-08-10 22:18:55floriansetmessages: + msg5539
2016-08-10 17:50:38jendriksetmessages: + msg5533
2016-06-27 11:16:12jendriksetmessages: + msg5463
2016-06-07 17:14:37floriansetmessages: + msg5430
2016-06-06 17:17:57jendriksetstatus: unread -> reviewing
messages: + msg5426
2015-10-01 19:45:07floriansetnosy: + florian
2015-10-01 17:36:01jendrikcreate