Issue591

Title remove Heuristic::initialize()
Priority wish Status resolved
Superseder Nosy List jendrik, malte, manuel, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2015-11-10.09:55:27 by manuel, last changed by jendrik.

Messages
msg5485 (view) Author: jendrik Date: 2016-08-04.19:52:16
Merged and pushed.
msg5458 (view) Author: silvan Date: 2016-06-22.10:14:14
Experiments look good to me, too.
msg5457 (view) Author: jendrik Date: 2016-06-21.19:49:23
I think this should be sufficient, yes. From my point of view, this change is 
purely a change of when things are computed. The amount of stuff that's computed 
should be unchanged.

I think the experiments cover all affected heuristics.
msg5456 (view) Author: malte Date: 2016-06-21.19:46:11
Are you sure the IPC14 benchmarks are sufficient? (If you are, it's fine with me.)

Did you test all affected heuristics?
msg5455 (view) Author: jendrik Date: 2016-06-21.19:42:43
I ran experiments on the IPC 2014 benchmarks (of course I forgot to exclude the ADL tasks in 
the optimal setting...):

http://ai.cs.unibas.ch/_tmp_files/seipp/issue591-v1-opt-issue591-base-issue591-v1-compare.html
http://ai.cs.unibas.ch/_tmp_files/seipp/issue591-v1-sat-issue591-base-issue591-v1-compare.html

While at it, I also revamped the common_setup.py interface a bit. As a result the interface is 
now closer to the base FastDownwardExperiment. This should make it easier to switch back and 
forth between the two for private and issue experiments.
msg5454 (view) Author: malte Date: 2016-06-20.17:26:25
Please run experiments first. I'll have a look at the code afterwards.
msg5453 (view) Author: jendrik Date: 2016-06-20.11:19:31
The first round of reviews is done, I guess. Malte, do you want to have a look at 
the code? Shall I run experiments?

https://bitbucket.org/jendrikseipp/downward/pull-requests/53
msg5432 (view) Author: malte Date: 2016-06-07.23:08:16
Please do the first round of reviews without me -- no time in the immediate future.
msg5428 (view) Author: silvan Date: 2016-06-07.10:27:15
I had a look and made two comments.
msg5427 (view) Author: jendrik Date: 2016-06-06.23:29:18
I have made a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/53. Can someone have a 
look, please?
msg4750 (view) Author: jendrik Date: 2015-11-10.11:02:44
Changed the title to reflect the primary task of this issue. We agreed to move 
the code from "initialize()" to the respective constructors. Once this is done, 
measuring the times of the different stages should be easier.
msg4749 (view) Author: malte Date: 2015-11-10.10:46:15
Currently there is still a use. We first have to change the current
"initialize()" structure. Can the two of you discuss the details between
yourselves? If you need further input from me, of course feel free to ask.
msg4746 (view) Author: manuel Date: 2015-11-10.09:55:27
Remove output of actual search time, as there is no use for it anymore.
History
Date User Action Args
2016-08-04 19:52:16jendriksetstatus: reviewing -> resolved
messages: + msg5485
2016-06-22 10:14:14silvansetmessages: + msg5458
2016-06-21 19:49:23jendriksetmessages: + msg5457
2016-06-21 19:46:11maltesetmessages: + msg5456
2016-06-21 19:42:44jendriksetmessages: + msg5455
2016-06-20 17:26:25maltesetmessages: + msg5454
2016-06-20 11:19:31jendriksetmessages: + msg5453
2016-06-07 23:08:16maltesetmessages: + msg5432
2016-06-07 10:27:15silvansetmessages: + msg5428
2016-06-06 23:29:18jendriksetstatus: chatting -> reviewing
assignedto: jendrik
messages: + msg5427
2015-11-10 11:02:44jendriksetmessages: + msg4750
title: remove actual search time -> remove Heuristic::initialize()
2015-11-10 10:50:35silvansetnosy: + silvan
2015-11-10 10:46:15maltesetstatus: unread -> chatting
messages: + msg4749
2015-11-10 09:55:27manuelcreate