Issue631

Title Make EHC Implementation Consistent with FF
Priority wish Status resolved
Superseder Nosy List erez, joerg, malte
Assigned To erez Keywords
Optional summary
In FF, EHC did not do global duplicate detection.  (Issue originally identified 
by Maximilian and Joerg)
The current implementation in FD does. 

The attached patch adds a flag for choosing the correct behavior.
We might also want to eliminate cycles from the plan.

Created on 2016-02-03.14:39:20 by erez, last changed by malte.

Summary
In FF, EHC did not do global duplicate detection.  (Issue originally identified 
by Maximilian and Joerg)
The current implementation in FD does. 

The attached patch adds a flag for choosing the correct behavior.
We might also want to eliminate cycles from the plan.
Files
File name Uploaded Type Edit Remove
ehc.patch erez, 2016-02-03.14:39:20 text/x-patch
Messages
msg11219 (view) Author: malte Date: 2023-07-28.10:37:36
I am closing this; the intention to make our EHC implementation more "standard" is good, but I think there are other, more substantial differences that would be more important to address (e.g. the lazy search nature of the implementation), and for this I think it would be better to keep the logic simple.

Also, with our current state space implementation, at the level of the search space we must necessarily do global duplicate elimination anyway, so the form that "does not" do it actually does some kind of hybrid, which I think is hard to explain, too.
History
Date User Action Args
2023-07-28 10:37:36maltesetstatus: chatting -> resolved
messages: + msg11219
2016-02-03 14:42:37erezsetsummary: In FF, EHC did not do global duplicate detection. (Issue originally identified by Maximilian and Joerg) The current implementation in FD does. The attached patch adds a flag for choosing the correct behavior. -> In FF, EHC did not do global duplicate detection. (Issue originally identified by Maximilian and Joerg) The current implementation in FD does. The attached patch adds a flag for choosing the correct behavior. We might also want to eliminate cycles from the plan.
2016-02-03 14:40:10erezsetnosy: + joerg
2016-02-03 14:39:20erezcreate