Issue670

Title M&S refactoring part 2: add a verbose option
Priority wish Status resolved
Superseder Nosy List malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2016-09-04.17:50:04 by silvan, last changed by silvan.

Messages
msg5608 (view) Author: silvan Date: 2016-09-06.11:35:05
Pushed.
msg5607 (view) Author: malte Date: 2016-09-06.11:30:56
Yes, sounds good (no experiments needed).
msg5606 (view) Author: silvan Date: 2016-09-06.11:30:37
I assume we do not need experiments, do we? If not, I'll merge this issue and
re-create a pull request for issue668.
msg5605 (view) Author: malte Date: 2016-09-06.11:27:29
Looks good, thanks!
msg5604 (view) Author: silvan Date: 2016-09-06.11:17:32
I am done making the discussed changes; please see merge_and_shrink_heuristic.cc
and shrink_strategy.* (or the single commits).
msg5603 (view) Author: silvan Date: 2016-09-06.09:51:05
I answered a few comments and agree with the rest (did not push yet so that the
comments are still easily visible in the pull request).
msg5602 (view) Author: malte Date: 2016-09-05.19:53:32
I'm done making comments on bitbucket.
msg5599 (view) Author: silvan Date: 2016-09-05.11:49:05
I added a VerboseLevel option. The change affects many files, but it is still
fairly simple: https://bitbucket.org/SilvanS/fd-dev/pull-requests/21/issue670/diff
msg5593 (view) Author: silvan Date: 2016-09-04.17:50:04
As discussed in issue668, we want to make the change that adds a verbose option
"all over the place" in merge-and-shrink in a separate issue, to ease reviewing.

More precisely, I thought of having a general verbose option for the heuristic,
but not for all other components. All other components will have a verbose
parameter for their main methods to enable or disable producing logging output.
History
Date User Action Args
2016-09-06 11:35:05silvansetstatus: in-progress -> resolved
messages: + msg5608
2016-09-06 11:30:56maltesetmessages: + msg5607
2016-09-06 11:30:37silvansetmessages: + msg5606
2016-09-06 11:27:29maltesetmessages: + msg5605
2016-09-06 11:17:32silvansetmessages: + msg5604
2016-09-06 09:51:05silvansetmessages: + msg5603
2016-09-05 19:53:32maltesetmessages: + msg5602
2016-09-05 11:49:05silvansetstatus: chatting -> in-progress
messages: + msg5599
2016-09-04 17:50:04silvancreate