Issue719

Title clean up option parser
Priority feature Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2017-04-25.14:47:35 by jendrik, last changed by jendrik.

Messages
msg6305 (view) Author: jendrik Date: 2017-04-30.22:02:49
Done :-)
msg6303 (view) Author: malte Date: 2017-04-30.21:42:08
Yes, please merge.
msg6301 (view) Author: jendrik Date: 2017-04-30.21:33:04
Thanks for your comments! I have taken care of them and checked that the help and 
txt2tags output hasn't changed. Can I go ahead and merge this?
msg6269 (view) Author: malte Date: 2017-04-28.13:55:59
I had a brief look at some, but not all of the code and left a few comments.
Before merging, I think we should verify that the before/after output of the
option parser's "dump all options" features (for humans and for txt2tags) remain
the same.
msg6259 (view) Author: jendrik Date: 2017-04-27.23:36:25
Done :-)
msg6250 (view) Author: malte Date: 2017-04-27.18:03:08
I'll have a look. If you're impatient, feel free to switch the position in the
queue with one of your other entries. ;-)
msg6244 (view) Author: jendrik Date: 2017-04-27.17:08:19
Thanks, Silvan! I'm done taking care of the comments. Malte, if you like, you could 
have a look at the pull request.
msg6243 (view) Author: silvan Date: 2017-04-27.16:56:53
I'm done with the first round of comments.
msg6232 (view) Author: jendrik Date: 2017-04-26.19:01:25
I have prepared a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/67
and added the issue to the reviewing queue.
msg6217 (view) Author: jendrik Date: 2017-04-25.14:47:35
While trying to understand the option parser, I will bring the option parser code 
closer to our coding conventions.
History
Date User Action Args
2017-04-30 22:02:49jendriksetstatus: in-progress -> resolved
messages: + msg6305
2017-04-30 21:42:08maltesetmessages: + msg6303
title: cleanup option parser -> clean up option parser
2017-04-30 21:33:04jendriksetmessages: + msg6301
2017-04-28 13:55:59maltesetmessages: + msg6269
2017-04-27 23:36:25jendriksetmessages: + msg6259
2017-04-27 18:03:08maltesetmessages: + msg6250
2017-04-27 17:08:19jendriksetmessages: + msg6244
2017-04-27 16:56:53silvansetmessages: + msg6243
2017-04-27 12:11:44silvansetnosy: + silvan
2017-04-26 19:01:25jendriksetmessages: + msg6232
2017-04-25 14:47:35jendrikcreate