Title M&S: not computing any distance information causes crashs
Priority bug Status resolved
Superseder Nosy List malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2017-10-31.14:00:36 by silvan, last changed by silvan.

msg6837 (view) Author: silvan Date: 2018-03-14.18:50:47
Thanks! Merged.
msg6835 (view) Author: malte Date: 2018-03-14.18:05:25
Done with the review, feel free to merge after the stuff we discussed.
msg6701 (view) Author: malte Date: 2017-12-04.12:37:19
Unfortunately I fear this will have to wait until I have had time to catch up
with the review queue, unless you can convince Jendrik and Florian to let you
move to the front.
msg6655 (view) Author: silvan Date: 2017-11-30.15:14:22
I just noticed that I didn't paste the pull request link:
msg6590 (view) Author: silvan Date: 2017-11-05.21:28:55
I ran experiments in debug an release mode with random shrinking and linear
merging (both do not require any distance information) and the four different
possible pruning options to test the different behavior of computing g- and/or

No errors occurred and I think that one can now really prevent merge-and-shrink
from computing distances at all, except for goal distances when computing the
heuristic of course.

Here is the pull request, please don't feel urged (not a very large diff, but
neither extremely small. If I had to guess, I'd say 10-15minutes for looking at it):
msg6575 (view) Author: silvan Date: 2017-10-31.14:00:36
With issue707, we introduced the feature of determining which distance
information is required by the merge-and-shrink configuration. Hence if using a
merge-and-shrink configuration that does not require any distance information,
no distances will be computed. However, the merge-and-shrink code relies on
valid Distances objects at several places, even if not using the distance
information. Also, there is manual trigger that would compute goal distances
after computing the abstraction if not goal distances have been computed on the way.
Date User Action Args
2018-03-14 18:50:47silvansetstatus: reviewing -> resolved
messages: + msg6837
2018-03-14 18:05:25maltesetmessages: + msg6835
2017-12-04 12:37:19maltesetmessages: + msg6701
2017-11-30 15:14:22silvansetmessages: + msg6655
2017-11-05 21:28:55silvansetstatus: chatting -> reviewing
messages: + msg6590
2017-10-31 14:00:36silvancreate