This has already been merged some weeks ago.

Marking as resolved.

Looks good to merge then.

The code works for my Mercurial version 3.7.3.

Looks good to me.

Should work now, I added AI Basel access to the wrong repo.

I get an "Access denied" error.

Here is a clean solution (tested with my Mercurial version):
https://bitbucket.org/PatFer/downward/pull-requests/2/fix-issue765/diff

Thanks for looking into this! Can you prepare a pull request to make this easier
to review?

Jendrik, can you test if the new uncrustify.py works for you?

You can see the clean way to provide a fallback in the try/except block at the
top of the file. I would try to import the "command" decorator, and if it is not
present, implement a do-nothing decorator with something like:

def command(*args, **kwargs):
    def identity_decorator(f):
        return f
    return identity_decorator

(I can provide more details with a pull request.)

Having said that, we don't necessarily have to bother with supporting Mercurial
1.9 or older. hg uncrustify is only an internal tool, and Mercurial 2.0 was
released in 2011. Our oldest software versions are usually the ones on the
sciCORE grid, and on the new login node the default version of Mercurial is 2.6
(from 2013). On aidev, which needs hg for the build master, we have Mercurial
2.8. Not sure about the build slaves, but if they cause problems, we will find
it out.

If you do want to test an older version, they are available on
https://www.mercurial-scm.org/release/?M=D

When using REPO/misc/style/uncrustify with mercurial version 4.3.1 I get an
error (see end) about failing to import because of missing attributes and that
we should use @command to register the uncrustify action.

In the attached file I fixed the problem by trying the @command  decorator
(mercurial >= 1.9)  and if failing using the old way.

If my approach would be used, do we have someone with mercurial < 1.9 to check
if the fall back works? And what would be the correct Exception to catch?



*** failed to import extension uncrustify from
/home/ferber/repositories/issue762/misc/style/uncrustify.py: missing attributes:
norepo, optionalrepo, inferrepo
*** (use @command decorator to register 'uncrustify')                           
hg uncrustify: option -X not recognized 
alias 'uncrustify' resolves to unknown command 'uncrustify'