Issue768

Title iPDB: calculate sample h-values only once for incumbent collection
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2018-03-16.19:30:35 by jendrik, last changed by jendrik.

Messages
msg6969 (view) Author: jendrik Date: 2018-04-02.22:29:49
Merged and pushed.
msg6968 (view) Author: malte Date: 2018-04-02.22:07:37
Sounds good to merge then. I guess it would make sense to do something about
running out of memory at some point, but that shouldn't block this issue.
msg6967 (view) Author: jendrik Date: 2018-04-02.21:12:08
Here are the experimental results for iPDB with a 900s time limit:

http://ai.cs.unibas.ch/_tmp_files/seipp/issue768-v1-opt-issue768-base-issue768-v1-compare.html
http://ai.cs.unibas.ch/_tmp_files/seipp/issue768-v1-opt-total_time-ipdb-issue768-base-issue768-v1.png
http://ai.cs.unibas.ch/_tmp_files/seipp/issue768-v1-opt-memory-ipdb-issue768-base-issue768-v1.png

Hill climbing often runs much faster with this patch. The difference in memory usage for some tasks 
probably stems from different pattern collections being generated.  

Coverage decreases by 3 in airport due to running out of memory during hill climbing. This is due to 
the ~2x increase in speed during hill climbing which allows generating more patterns. Coverage 
increases by 1 in logistics00 and parcprinter-08-strips.
msg6962 (view) Author: malte Date: 2018-03-31.16:06:40
The code change is local enough that I'm happy to defer to Florian's review, so
no review needed from my side.

Can we see experimental results?
msg6943 (view) Author: florian Date: 2018-03-17.22:00:14
The code looks all right to me.
msg6942 (view) Author: jendrik Date: 2018-03-17.12:26:58
Sorry about that. You should have access now.
msg6941 (view) Author: florian Date: 2018-03-17.11:59:47
I got an "Access Denied" message.
msg6933 (view) Author: jendrik Date: 2018-03-16.19:45:09
I made a pull request at https://bitbucket.org/jendrikseipp/downward/pull-requests/80 .
msg6930 (view) Author: jendrik Date: 2018-03-16.19:30:35
This change should speed up the hill climbing algorithm.
History
Date User Action Args
2018-04-02 22:29:49jendriksetstatus: reviewing -> resolved
messages: + msg6969
2018-04-02 22:07:37maltesetmessages: + msg6968
2018-04-02 21:12:08jendriksetmessages: + msg6967
2018-03-31 16:06:40maltesetmessages: + msg6962
2018-03-17 22:00:14floriansetmessages: + msg6943
2018-03-17 19:21:10silvansetnosy: + silvan
2018-03-17 12:26:58jendriksetmessages: + msg6942
2018-03-17 11:59:47floriansetnosy: + florian
messages: + msg6941
2018-03-16 19:45:09jendriksetstatus: unread -> reviewing
messages: + msg6933
2018-03-16 19:30:35jendrikcreate