Issue773

Title add min_pruning_ratio parameter to stubborn sets methods
Priority feature Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2018-04-08.10:04:06 by jendrik, last changed by jendrik.

Messages
msg7054 (view) Author: jendrik Date: 2018-04-15.09:50:20
I handled your comments, merged the code and pushed to the master repo.
msg7053 (view) Author: malte Date: 2018-04-13.21:04:00
LGTM. I added a few more comments on bitbucket.
msg7052 (view) Author: jendrik Date: 2018-04-13.20:07:42
Thanks for your comments, Malte! I agree with all of them and handled them in a 
single commit.
msg7041 (view) Author: silvan Date: 2018-04-12.20:57:48
Okay, I'll wait anyways until you have updated the pull request. I just wanted
to look at the code out of curiosity, since I also implemented this for the IPC.
msg7038 (view) Author: jendrik Date: 2018-04-11.22:38:49
Silvan, I don't think a second review is necessary now that Malte had a look at 
the code, but of course you're more than welcome to make comments :-)
msg7037 (view) Author: silvan Date: 2018-04-11.19:07:20
I'll also have a look once I find some time to do so.
msg7036 (view) Author: malte Date: 2018-04-11.19:03:28
I left some code review comments.
msg7030 (view) Author: jendrik Date: 2018-04-11.08:51:34
Here are the results for an experiment evaluating the current patch.

http://ai.cs.unibas.ch/_tmp_files/seipp/issue773-v1-opt-issue773-base-issue773-v1-compare.html

The left comparison compares plain simple stubborn sets and simple stubborn sets with 
min_pruning_ratio=0.2, i.e., pruning is diabled after 1000 expansions if not at least 0.2 of 
the successors have been pruned (for simplicity the two configs use the same config and the 
parser of the base version just ignores the unknown min_pruning_ratio argument). The right 
comparison checks that the plain simple stubborn sets (without min_pruning_ratio) are not 
affected by the patch.

Using min_pruning_ratio=0.2 raises the coverage of LM-cut by 11 tasks. 8 domains are affected 
positively by the change while coverage decreases by 1 in Rovers. The patch doesn't seem to 
affect the code path taken without min_pruning_ratio.
msg7021 (view) Author: jendrik Date: 2018-04-09.18:59:23
Silvan, could you please review the code?
msg7008 (view) Author: jendrik Date: 2018-04-08.10:57:23
I made a pull request at
https://bitbucket.org/jendrikseipp/downward/pull-requests/81 .
History
Date User Action Args
2018-04-15 09:50:20jendriksetstatus: reviewing -> resolved
messages: + msg7054
2018-04-13 21:04:01maltesetmessages: + msg7053
2018-04-13 20:07:42jendriksetmessages: + msg7052
2018-04-12 20:57:48silvansetmessages: + msg7041
2018-04-11 22:38:49jendriksetmessages: + msg7038
2018-04-11 19:07:20silvansetmessages: + msg7037
2018-04-11 19:03:28maltesetmessages: + msg7036
2018-04-11 08:51:34jendriksetmessages: + msg7030
2018-04-09 18:59:23jendriksetmessages: + msg7021
2018-04-08 12:35:29silvansetnosy: + silvan
2018-04-08 10:57:23jendriksetstatus: unread -> reviewing
messages: + msg7008
title: add min_pruning_ratio parameter to pruning methods -> add min_pruning_ratio parameter to stubborn sets methods
2018-04-08 10:04:06jendrikcreate