Issue784

Title use clearer and/or more consistent parameter names in a few places
Priority wish Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2018-05-01.11:12:53 by jendrik, last changed by jendrik.

Messages
msg7762 (view) Author: jendrik Date: 2018-09-21.23:32:26
Reverted "block_x" to "block" in the header and merged.
msg7759 (view) Author: malte Date: 2018-09-21.18:18:49
Looks good to me. I would not have changed "block" to "block_x" in the header
file, but feel free to include that change if you consider it an improvement.
msg7757 (view) Author: jendrik Date: 2018-09-21.18:05:37
I merged the current master into the issue branch.
msg7159 (view) Author: jendrik Date: 2018-06-04.14:08:47
Change title to reflect that we don't want to enforce using the same variable 
names in function declarations and definitions.
msg7107 (view) Author: jendrik Date: 2018-05-01.22:06:22
I agree that a clean interface is more desirable than consistent names. I don't 
think (anymore) that we should enforce that the same names are used in the 
declaration and definition and therefore disabled the clang-tidy check again 
and reverted most of the changes.

I think the current patch makes some names clearer and adds a bit of 
consistency, but I'd also be fine with not merging it.
msg7106 (view) Author: malte Date: 2018-05-01.19:30:27
I've left a bunch of comments. (See also
http://www.fast-downward.org/ForDevelopers/CodingConventions under
"Anti-idioms". You added the relevant line in revision 19 of that page.)

I don't mind a bit of consistency, but I think the added value here is
questionable because many of the changes go in a bad direction, and I think
there are better ways to use of our resources. But if nobody is unhappy with it,
I don't mind the change if you can address the comments on bitbucket.
msg7105 (view) Author: jendrik Date: 2018-05-01.19:11:50
I made a pull request at https://bitbucket.org/jendrikseipp/downward/pull-requests/86 .
History
Date User Action Args
2018-09-21 23:32:26jendriksetstatus: reviewing -> resolved
messages: + msg7762
2018-09-21 18:18:49maltesetmessages: + msg7759
2018-09-21 18:05:37jendriksetmessages: + msg7757
2018-06-04 14:08:47jendriksetmessages: + msg7159
title: clang-tidy: check that parameter names in declaration and definition match -> use clearer and/or more consistent parameter names in a few places
2018-05-01 22:06:22jendriksetmessages: + msg7107
2018-05-01 19:30:27maltesetmessages: + msg7106
2018-05-01 19:11:50jendriksetstatus: unread -> reviewing
messages: + msg7105
2018-05-01 11:12:53jendrikcreate