Issue801

Title switch to newer uncrustify version
Priority wish Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2018-06-16.09:53:55 by jendrik, last changed by jendrik.

Messages
msg7293 (view) Author: jendrik Date: 2018-07-10.15:10:53
Merged.
msg7262 (view) Author: malte Date: 2018-06-16.22:39:47
Sounds good to me. All code changes in the pull request look like
improvements/fixes to me.
msg7261 (view) Author: jendrik Date: 2018-06-16.21:11:59
I ran uncrustify 0.66.1 (the version in Ubuntu 18.04) on our codebase. The main changes are:
  
* uncrustify >= 0.65 changed the name of the option "align_number_left" to "align_number_right" 
* uncrustify 0.66.1 removes whitespace between ; and } in one-liner method definitions.
* uncrustify 0.66.1 adds whitespace between "friend std" and "::ostream".

The second change is ok or maybe even preferable since the behavior of uncrustify 0.61 is rather 
surprising for these one-liners. The third change is obviously a bug. Fortunately, this bug has 
been fixed in version 0.67. Therefore, I propose to switch to uncrustify 0.67. The following 
pull request shows the changes incurred by the switch.

https://bitbucket.org/jendrikseipp/downward/pull-requests/94

In a follow-up issue we might want to consider using the new option 
"indent_cpp_lambda_body=true" to make the indentation of lambda functions more intuitive.
msg7260 (view) Author: jendrik Date: 2018-06-16.09:53:54
In issue799 we came to the conclusion that switching to a newer uncrustify 
version is preferable to switching to clang-format. We would like to test whether 
uncrustify 0.66 fixes the shortcomings of uncrustify 0.61 and correctly formats 
C++11 code.
History
Date User Action Args
2018-07-10 15:10:53jendriksetstatus: reviewing -> resolved
messages: + msg7293
2018-06-16 22:39:47maltesetmessages: + msg7262
2018-06-16 21:11:59jendriksetstatus: unread -> reviewing
assignedto: jendrik
messages: + msg7261
2018-06-16 09:53:55jendrikcreate