Issue834

Title remove traces of old Plugin class
Priority feature Status resolved
Superseder Nosy List cedric, jendrik, malte, patfer, silvan
Assigned To cedric Keywords
Optional summary
part of issue588

Created on 2018-09-19.20:19:26 by jendrik, last changed by cedric.

Summary
part of issue588
Messages
msg7641 (view) Author: cedric Date: 2018-09-20.14:11:11
Issue is merged
msg7628 (view) Author: malte Date: 2018-09-20.11:42:57
Agreed. Everything looks good, and if there is something we overlooked, we will
hear from the buildbot and/or autodoc. :-)
msg7626 (view) Author: jendrik Date: 2018-09-20.11:34:31
Code looks good to me (apart from one trivial comment). I think this can be 
merged.
msg7617 (view) Author: patfer Date: 2018-09-20.10:08:29
looks good for me. let's wait for somebody else opinion.
msg7615 (view) Author: cedric Date: 2018-09-20.09:50:04
All 3 steps are addressed. Here is the PR
https://bitbucket.org/cgeissmann/downward/pull-requests/9/issue834/diff
msg7607 (view) Author: jendrik Date: 2018-09-19.20:19:26
Quoting Malte in msg7602: [Now that issue526 is merged, we can] remove the traces of the old 
class Plugin from the code. I suggest doing this in the following steps, which in my opinion 
can be done in the same issue, but I would do them in separate commits:

1. Remove code related to the class Plugin.
   I think all this code should be in the option parser subdirectory.
   It is not enough to search for "Plugin". Also look for overloads of functions
   or templates that have a version for shared pointers and another one for
   raw pointers. Searching for the word "shared" in the option parser should
   probably find most or all relevant places: the code for raw pointers should
   be right next to the code for shared pointers.

2. Optionally, clean up the method names etc. in the option parser that
   previously included the word "shared" to distinguish them from the
   raw pointer versions.

3. Rename the class PluginShared to Plugin. (This will touch lots of source
   files, so should be a commit of its own.)
History
Date User Action Args
2018-09-20 14:11:11cedricsetstatus: chatting -> resolved
messages: + msg7641
2018-09-20 11:42:57maltesetmessages: + msg7628
2018-09-20 11:34:31jendriksetmessages: + msg7626
2018-09-20 10:08:30patfersetnosy: + patfer
messages: + msg7617
2018-09-20 10:01:26silvansetnosy: + silvan
2018-09-20 09:50:04cedricsetstatus: unread -> chatting
messages: + msg7615
2018-09-20 07:53:36cedricsetassignedto: cedric
2018-09-20 07:51:13cedricsetnosy: + cedric
2018-09-19 20:19:59jendriksetsummary: part of issue588
2018-09-19 20:19:26jendrikcreate