Issue853

Title Update FindCplex CMake script
Priority feature Status resolved
Superseder Nosy List augusto, florian, jendrik, malte
Assigned To augusto Keywords
Optional summary
This is required for issue852.

Created on 2018-10-09.17:14:42 by florian, last changed by florian.

Summary
This is required for issue852.
Messages
msg7935 (view) Author: florian Date: 2018-10-10.09:19:22
I pushed the changes now.

Augusto, in our workflow we close issue branches before merging them. I fixed
this in your bitbucket repo but I had to strip the merge commit. To avoid any
problems with your local clone, you should execute
  hg strip bf80515439c6
  hg pull -u
msg7934 (view) Author: jendrik Date: 2018-10-09.23:49:05
Augusto, have you pushed your changes to the main repository? I can't see them 
there.
msg7933 (view) Author: malte Date: 2018-10-09.19:32:35
Thanks, Augusto! If it works, please set this 
to resolved.
msg7932 (view) Author: augusto Date: 2018-10-09.19:06:07
I tested the release64 build on the Windows machine and it still works after the
changes proposed by Florian. I just merged the pull request.
msg7931 (view) Author: florian Date: 2018-10-09.18:40:09
Augusto wrote a patch for this and I left some comments on bitbucket, mostly
about making the find script general enough that it could be re-used outside of
Fast Downward. 

The pull request is here:
https://bitbucket.org/gutoblaas/downward/pull-requests/3

If it works on the buildbot, we can merge it.
msg7929 (view) Author: florian Date: 2018-10-09.17:14:42
CMake uses the find script to locate CPLEX. This requires special cases for each
Visual Studio and CPLEX version. The current script only handles cases up to VS
2013 and CPLEX 12.62. Here we want to update it to also handle VS 2015/2017 and
CPLEX 12.8.
History
Date User Action Args
2018-10-10 09:19:22floriansetstatus: in-progress -> resolved
messages: + msg7935
2018-10-09 23:49:05jendriksetmessages: + msg7934
2018-10-09 19:32:35maltesetmessages: + msg7933
2018-10-09 19:06:07augustosetmessages: + msg7932
2018-10-09 18:40:09floriansetmessages: + msg7931
2018-10-09 17:14:42floriancreate