Issue873

Title Make option parser planner-independent
Priority wish Status resolved
Superseder Nosy List cedric, jendrik, malte, patfer
Assigned To patfer Keywords
Optional summary

Created on 2018-12-05.14:06:51 by patfer, last changed by jendrik.

Messages
msg8363 (view) Author: jendrik Date: 2018-12-15.17:08:31
Done.
msg8360 (view) Author: malte Date: 2018-12-15.16:52:18
I don't think the issue has actually been merged.
Can you do that?
msg8358 (view) Author: malte Date: 2018-12-15.16:41:30
I think it's fine. There are some small things that should eventually be
addressed, like constructors that should be explicit and exception classes that
should behave more like normal exceptions, but that doesn't have to be part of
this issue.
msg8355 (view) Author: jendrik Date: 2018-12-14.17:12:58
If you see any problems with the code, Malte, we're happy to fix them in the
default branch.
msg8352 (view) Author: cedric Date: 2018-12-14.16:28:36
We decided to merge this to get the haslums.
msg8348 (view) Author: jendrik Date: 2018-12-14.15:51:34
Code looks good to me. Malte, can we merge this?
msg8344 (view) Author: cedric Date: 2018-12-14.15:24:28
Incorporated Jendriks comments.

A minimal build only for src/options and src/utils works.
msg8330 (view) Author: jendrik Date: 2018-12-14.13:04:57
I left two comments at Bitbucket.
msg8323 (view) Author: cedric Date: 2018-12-14.11:57:05
I Updated Patricks PR. Can someone have a look at it?

https://bitbucket.org/cgeissmann/downward/pull-requests/10/issue873/diff
msg8179 (view) Author: cedric Date: 2018-12-07.11:44:50
I also left some comments on Bitbucket.
msg8174 (view) Author: jendrik Date: 2018-12-06.19:49:52
I left some comments on Bitbucket and added a TODO to the summary.
msg8173 (view) Author: patfer Date: 2018-12-06.17:26:20
The current PR can be seen under 
https://bitbucket.org/PatFer/downward/pull-requests/12/issue873/diff

But the outstanding issue844 and issue831 will add code which needs to be changed.
msg8163 (view) Author: patfer Date: 2018-12-06.11:40:49
The option parser is mostly already planner independent. The planner dependent
part is once the

-commandline.cc separates the command line input and either forwards it to the
option parser or does its own stuff. The current idea is to move the
commandline.{h,cc} one directory up and out of the option parser.

-the option parser uses some code from utils. This is in general fine, as most
utility stuff is planner independent. Currently we are only aware of the Exit
Codes which are planner dependent chosen. Ways to get around  that are:
Require one specific ExitCode (e.g. OptionParserError) to exist, throw an
exception and the planner has to handle it (currently favored)
History
Date User Action Args
2018-12-15 17:08:31jendriksetmessages: + msg8363
2018-12-15 16:52:18maltesetmessages: + msg8360
2018-12-15 16:41:30maltesetmessages: + msg8358
2018-12-14 17:12:59jendriksetmessages: + msg8355
2018-12-14 16:28:36cedricsetstatus: in-progress -> resolved
messages: + msg8352
2018-12-14 15:51:34jendriksetmessages: + msg8348
2018-12-14 15:24:28cedricsetmessages: + msg8344
summary: TODO: Before merging, copy code from src/options and src/utils to an empty directory and try to compile everything. ->
2018-12-14 13:04:57jendriksetmessages: + msg8330
2018-12-14 11:57:05cedricsetmessages: + msg8323
2018-12-07 11:44:50cedricsetmessages: + msg8179
2018-12-06 19:49:52jendriksetmessages: + msg8174
summary: TODO: Before merging, copy code from src/options and src/utils to an empty directory and try to compile everything.
2018-12-06 17:26:20patfersetmessages: + msg8173
2018-12-06 11:40:49patfersetstatus: unread -> in-progress
messages: + msg8163
2018-12-05 14:06:51patfercreate