Issue881

Title use proper exception classes in option parser
Priority wish Status resolved
Superseder Nosy List cedric, jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2018-12-16.11:35:45 by jendrik, last changed by jendrik.

Messages
msg8495 (view) Author: jendrik Date: 2019-01-21.14:02:20
Merged.
msg8489 (view) Author: malte Date: 2019-01-21.12:50:45
Thanks! I'll extend it a little bit.

This issue looks good to merge, and probably should be merged if we refer to the
class it introduces in our coding conventions. :-) I didn't realize this was not
merged yet, sorry to keep you waiting.
msg8487 (view) Author: jendrik Date: 2019-01-21.12:38:19
Sure, why not. I added a short stub for this, didn't know what else to document.
msg8484 (view) Author: malte Date: 2019-01-21.12:22:30
Jendrik, is it worth saying something about exceptions on our coding conventions
page? This is one of these things where there are many different ways of
approaching things, and it would be good to stay consistent.
msg8394 (view) Author: jendrik Date: 2018-12-18.19:39:37
I made the changes we discussed.
msg8380 (view) Author: malte Date: 2018-12-18.13:16:13
I also had a look. Jendrik and I talked about our strategy for defining our own
exceptions more generally on bitbucket, and the pull request will go through
another iteration.
msg8372 (view) Author: silvan Date: 2018-12-17.11:09:37
I had a quick look at the PR and it looks good to me. However, I haven't checked
if the printed error messages look good; did you? Does it change to the previous
behavior? (From the code, I think it shouldn't, but who knows.)
msg8369 (view) Author: jendrik Date: 2018-12-16.12:26:08
Here is a pull request:
https://bitbucket.org/jendrikseipp/downward/pull-requests/114
msg8368 (view) Author: jendrik Date: 2018-12-16.11:35:45
Quoting Malte in issue873:

"There are some small things that should eventually be
addressed, like constructors that should be explicit and exception classes that
should behave more like normal exceptions [...]"
History
Date User Action Args
2019-01-21 14:02:20jendriksetstatus: reviewing -> resolved
messages: + msg8495
2019-01-21 12:50:45maltesetmessages: + msg8489
2019-01-21 12:38:19jendriksetmessages: + msg8487
2019-01-21 12:22:30maltesetmessages: + msg8484
2018-12-18 19:39:37jendriksetmessages: + msg8394
2018-12-18 13:16:13maltesetmessages: + msg8380
2018-12-17 11:09:37silvansetnosy: + silvan
messages: + msg8372
2018-12-17 09:13:42cedricsetnosy: + cedric
2018-12-16 12:26:08jendriksetstatus: unread -> reviewing
messages: + msg8369
2018-12-16 11:35:45jendrikcreate