Issue892

Title Change interface of PatternGenerators to allow returning pattern and the corresponding PDB
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2019-02-18.15:29:41 by silvan, last changed by silvan.

Messages
msg8655 (view) Author: silvan Date: 2019-03-08.16:49:23
Thanks, merged.
msg8653 (view) Author: jendrik Date: 2019-03-08.14:54:37
I left one comment, bu otherwise this looks good to be merged from my side.
msg8651 (view) Author: malte Date: 2019-03-08.12:36:25
All sounds good and in keeping with how I remember our discussion in yesterday's
live meeting.
msg8650 (view) Author: silvan Date: 2019-03-08.12:28:52
I made a few more small changes to PatternInformation.

For the time being, I'd suggest to keep PatternInformation and
PatternCollectionInformation independent from each other even though they are
similar to each other and PCI could possibly re-use PI as suggested by Florian.
That way, all of the generators have a similar interface for now.

I think that we should deal with changing the way how we pass around pattern
collections, possibly with their PDBs, in a separate issue. (We discussed that
it would be good to have patterns and PDBs together, both for making changes to
the collection and for possibly avoiding to store the pattern next to the PDB
and in the PDB).
msg8552 (view) Author: jendrik Date: 2019-02-27.14:43:23
I added this to the agenda.
msg8551 (view) Author: silvan Date: 2019-02-27.14:26:55
Jendrik again brought up the question whether we actually want to keep
PatternGenerator next to PatternCollectionGenerator. I suggest to discuss this
offline at some point; maybe at the next Fast Downward meeting next week.
msg8550 (view) Author: silvan Date: 2019-02-27.12:10:31
I addressed them.
msg8549 (view) Author: jendrik Date: 2019-02-27.12:06:12
I left some comments.
msg8547 (view) Author: silvan Date: 2019-02-27.11:37:55
I implemented my suggestion:
https://bitbucket.org/SilvanS/fd-dev/pull-requests/44/issue892/diff

Any reviewers?
msg8531 (view) Author: malte Date: 2019-02-18.18:53:25
I'll stay out of this discussion for now. I don't know the code well enough to
have an opinion.
msg8530 (view) Author: silvan Date: 2019-02-18.16:19:07
For users like the PDBHeuristic, having a distinction between a pattern or a
collection generator makes sense. Also for use cases like ours where a
collection generator repeatedly calls to a pattern generator. So I think would
slightly favor to keep the distinction but to not only return a pattern, but a
wrapper that allows to also return the PDB.
msg8529 (view) Author: jendrik Date: 2019-02-18.16:07:19
I like the idea. This raises the question whether we still want
PatternGenerators at all since they could just become PatternCollectionGenerators.
msg8528 (view) Author: silvan Date: 2019-02-18.15:29:41
Working with pattern generators recently, I realized that even though some of my
generators may compute a "singleton pattern collection", i.e., a simple pattern,
it it more convenient to actually compute a collection containing a single
element because this allows using the PatternCollectionInformation interface
which in turn allows keeping the potentially already computed PDB corresponding
to the pattern. Since the only pattern generator currently contained in the
default branch (besides the manual one) is the greedy one and this isn't
frequently used to my knowledge, I suggest changing the interface of
PatternGenerator to either PatternCollectionInformation, or, probably more
properly, to something like PatternInformation, where the generator may include
the already computed PDB if it likes to.
History
Date User Action Args
2019-03-08 16:49:23silvansetstatus: reviewing -> resolved
messages: + msg8655
2019-03-08 14:54:37jendriksetmessages: + msg8653
2019-03-08 12:36:25maltesetmessages: + msg8651
2019-03-08 12:28:52silvansetmessages: + msg8650
2019-02-27 14:43:23jendriksetmessages: + msg8552
2019-02-27 14:26:55silvansetmessages: + msg8551
2019-02-27 12:10:32silvansetmessages: + msg8550
2019-02-27 12:06:12jendriksetassignedto: silvan
messages: + msg8549
2019-02-27 11:37:55silvansetstatus: chatting -> reviewing
messages: + msg8547
2019-02-18 18:53:25maltesetstatus: unread -> chatting
messages: + msg8531
2019-02-18 16:19:07silvansetstatus: chatting -> unread
messages: + msg8530
2019-02-18 16:07:19jendriksetstatus: unread -> chatting
messages: + msg8529
2019-02-18 15:30:56floriansetnosy: + florian
2019-02-18 15:29:41silvancreate