Issue899

Title store LandmarkNodes in vector<unique_ptr>
Priority wish Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To jendrik Keywords
Optional summary

Created on 2019-03-02.11:21:25 by jendrik, last changed by jendrik.

Messages
msg8636 (view) Author: jendrik Date: 2019-03-07.23:22:52
Merged.
msg8631 (view) Author: malte Date: 2019-03-07.18:39:05
Following today's meeting: I didn't review Jendrik's changes again thoroughly,
but from my side this can be merged.
msg8620 (view) Author: malte Date: 2019-03-06.00:14:24
I left some comments. I have a few question marks, but it may be better to
ignore them than keeping this up further, as I'm not sure I'll find time to
discuss them this week.
msg8609 (view) Author: silvan Date: 2019-03-05.14:25:29
Was more directed at Jendrik. But I agree that this doesn't have to be answered
or dealt with here.
msg8608 (view) Author: malte Date: 2019-03-05.12:16:12
Not sure if the question is directed at Jendrik or me, but generally speaking
the landmark code is in dire need of more general polish. I would be somewhat
reluctant to invest much time in local improvements before having looked at
things more globally; they may turn out to be wasted effort in the end.

So focusing primarily on the memory management here makes some sense to me. But
of course that's always a case-by-case decision.
msg8607 (view) Author: silvan Date: 2019-03-05.12:11:19
I left a few comments. Overall, this looks good.

I was wondering, though, if we still need so many places where we use raw
pointers of landmark nodes for hashing and/or comparing landmark nodes (I
assume). Basically, we now control the landmark nodes using unique_ptr and we
store them in a vector instead of a set, but we have still plenty of places
where we access and also store the raw pointers. Do you think that this could be
changed at all? If so, it might be a different issue of course.
msg8603 (view) Author: jendrik Date: 2019-03-05.09:07:31
Silvan, are you up for a review?
msg8589 (view) Author: jendrik Date: 2019-03-03.19:15:54
The results are in:

https://ai.dmi.unibas.ch/_tmp_files/seipp/issue899-v1-opt-issue899-base-issue899-v1-compare.html
https://ai.dmi.unibas.ch/_tmp_files/seipp/issue899-v1-sat-issue899-base-issue899-v1-compare.html

The patch makes the landmarks code considerably faster. This leads to solving
four more intances for the lm_hm configuration. Otherwise coverage is not
affected much.

Here is a scatter plot for the total_time needed by BJOLP:
https://ai.dmi.unibas.ch/_tmp_files/seipp/issue899-v1-opt-issue899-base-issue899-v1-total_time-seq-opt-bjolp.png
msg8586 (view) Author: malte Date: 2019-03-03.12:37:31
I'll have a look once the experiments are done.
msg8585 (view) Author: jendrik Date: 2019-03-03.00:17:09
I made a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/124 .
History
Date User Action Args
2019-03-07 23:22:52jendriksetstatus: reviewing -> resolved
messages: + msg8636
2019-03-07 18:39:05maltesetmessages: + msg8631
2019-03-06 00:14:24maltesetmessages: + msg8620
2019-03-05 14:25:29silvansetmessages: + msg8609
2019-03-05 12:16:12maltesetmessages: + msg8608
2019-03-05 12:11:19silvansetmessages: + msg8607
2019-03-05 09:07:31jendriksetmessages: + msg8603
2019-03-03 19:15:54jendriksetmessages: + msg8589
2019-03-03 12:37:31maltesetmessages: + msg8586
2019-03-03 00:17:09jendriksetstatus: in-progress -> reviewing
messages: + msg8585
2019-03-02 14:26:26silvansetnosy: + silvan
2019-03-02 11:21:25jendrikcreate