I left a few comments. Overall, this looks good.
I was wondering, though, if we still need so many places where we use raw
pointers of landmark nodes for hashing and/or comparing landmark nodes (I
assume). Basically, we now control the landmark nodes using unique_ptr and we
store them in a vector instead of a set, but we have still plenty of places
where we access and also store the raw pointers. Do you think that this could be
changed at all? If so, it might be a different issue of course.
|