Issue921

Title add verbosity option to all heuristics/those heuristics that produce lots of output
Priority feature Status chatting
Superseder Nosy List jendrik, malte, manuel, silvan
Assigned To manuel Keywords
Optional summary

Created on 2019-06-07.11:28:12 by silvan, last changed by silvan.

Messages
msg8898 (view) Author: silvan Date: 2019-06-14.10:37:23
Thanks! I left a few more comments on the diff. Jendrik, I'll leave thinking
about levels of the CEGAR output to you :-)
msg8894 (view) Author: manuel Date: 2019-06-13.11:07:58
Here are the outputs of the different configurations.
I think providing the output is better than providing the pairwise diffs.

http://ai.cs.unibas.ch/_tmp_files/heusner/ipdb-verbose.log
http://ai.cs.unibas.ch/_tmp_files/heusner/ipdb-normal.log
http://ai.cs.unibas.ch/_tmp_files/heusner/ipdb-silent.log

http://ai.cs.unibas.ch/_tmp_files/heusner/cegar-debug.log
http://ai.cs.unibas.ch/_tmp_files/heusner/cegar-verbose.log
http://ai.cs.unibas.ch/_tmp_files/heusner/cegar-normal.log
http://ai.cs.unibas.ch/_tmp_files/heusner/cegar-silent.log

http://ai.cs.unibas.ch/_tmp_files/heusner/diverse_potentials-verbose.log
http://ai.cs.unibas.ch/_tmp_files/heusner/diverse_potentials-normal.log
http://ai.cs.unibas.ch/_tmp_files/heusner/diverse_potentials-silent.log
msg8890 (view) Author: silvan Date: 2019-06-12.17:51:31
I added some initial comments.

I think that generally we want the verbosity option on the level of Heuristic
(possibly even Evaluator at some point). All heuristics not "supporting" that
option could document this. This way, the "add_verbosity_options..." could be
added once in the "add_heuristic_options...".

Also, some decisions regarding using VERBOSE or NORMAL seem a bit arbitrary at
this point. Furthermore, it is hard to make sure that each possible output is
guarded or was considered to be guarded by the verbosity level in case if it
should always be printed. I therefore suggest that you produce three diffs of
log files for affected configurations, so that we can discuss what should be
printed and what shouldn't at different levels.
msg8889 (view) Author: manuel Date: 2019-06-12.17:34:24
I added the verbosity option to the ipdb, cegar and diverse_potentials
heuristics. These were the three heuristics which produced the largest output in
issue744 (besides of to merge_and_shrink).

Here is the pull request:
https://bitbucket.org/manuel_h/downward/pull-requests/7/issue921/diff

It remains to discuss whether we want to provide the option to all heuristics.

Another issue is that for example cegar uses a landmark factory which produces
its own output. To control the output of a landmark factory, we would need the
verbosity option for landmark factories as well. Compared to the output of some
heuristics, the output of landmark factories is negligible.
msg8863 (view) Author: silvan Date: 2019-06-07.11:33:38
*now
msg8860 (view) Author: silvan Date: 2019-06-07.11:28:12
In issue744, we used the verbosity option from M&S for the search engines to be
able to reduce output during search. Some heuristics also produce lots of
output, e.g., iPDB or more generally, heuristics with a precomputation phase.
Adding support for the verbosity levels we know have for such heuristics should
be easy. We need to discuss if we want to use this feature for all heuristics or
rather only for some selected ones.
History
Date User Action Args
2019-06-14 10:37:23silvansetmessages: + msg8898
2019-06-13 11:07:58manuelsetmessages: + msg8894
2019-06-12 17:51:31silvansetmessages: + msg8890
2019-06-12 17:34:24manuelsetmessages: + msg8889
2019-06-12 14:22:30manuelsetnosy: + manuel
assignedto: manuel
2019-06-07 11:33:38silvansetpriority: wish -> feature
status: unread -> chatting
messages: + msg8863
2019-06-07 11:28:12silvancreate