Issue922

Title remove State copy constructor
Priority wish Status resolved
Superseder Nosy List cedric, jendrik, malte, manuel
Assigned To jendrik Keywords
Optional summary

Created on 2019-06-12.09:49:09 by jendrik, last changed by jendrik.

Messages
msg9985 (view) Author: jendrik Date: 2021-02-04.09:59:48
Now that issue348 made State objects cheap to copy, there's no need for this issue anymore.
msg8878 (view) Author: jendrik Date: 2019-06-12.11:46:31
I made a pull request at
https://bitbucket.org/jendrikseipp/downward/pull-requests/135 .
msg8875 (view) Author: malte Date: 2019-06-12.10:14:14
No objections in principle, although this is always a bit awkward as it goes a
bit against C++ philosophy. It would be nice if we could do things like these in
a less ad-hoc fashion.
msg8874 (view) Author: jendrik Date: 2019-06-12.09:49:09
While working on issue348 we noticed that our new code called the State copy
constructor even though we would have thought that copy-elision or return-value
optimization would prevent the copy. To avoid making expensive State copies by
mistake, we'd like to get rid of the State copy constructor.
History
Date User Action Args
2021-02-04 09:59:48jendriksetstatus: deferred -> resolved
messages: + msg9985
summary: Waiting for issue348 which might make this issue obsolete. ->
2019-06-14 15:29:22jendriksetstatus: reviewing -> deferred
2019-06-12 17:51:59jendriksetsummary: Waiting for issue348 which might make this issue obsolete.
2019-06-12 11:46:31jendriksetstatus: in-progress -> reviewing
messages: + msg8878
2019-06-12 11:03:40manuelsetnosy: + manuel
2019-06-12 10:14:14maltesetmessages: + msg8875
2019-06-12 10:01:56cedricsetnosy: + cedric
2019-06-12 09:49:09jendrikcreate