|
| msg9183 (view) |
Author: cedric |
Date: 2020-01-30.16:24:08 |
|
Removed TODOs.
Replaced clang-tidy-5.0 with clang-tidy-8 in all Docker containers.
|
| msg9182 (view) |
Author: jendrik |
Date: 2020-01-30.14:44:56 |
|
Thanks! I merged the issue branch. Feel free to close this once you updated the Docker images.
|
| msg9181 (view) |
Author: cedric |
Date: 2020-01-30.14:40:47 |
|
Added a new TODO item.
Yes I can install clang-tidy-8 in the Docker containers. I will remove the old version as soon as this issue is merged.
|
| msg9180 (view) |
Author: jendrik |
Date: 2020-01-30.10:47:22 |
|
OK, let's go ahead with clang-tidy-8 then. Cedric, can you please install clang-tidy-8 instead of clang-tidy-5.0 in the Docker containers?
|
| msg9177 (view) |
Author: malte |
Date: 2020-01-24.14:25:37 |
|
No objections to the pull request from my side. I don't know why the PyYAML thing is there, but I assume it's there for a reason. If someone wants to object to this, please speak up. No strong feelings about the version number as long as it's supported on the current stable Ubuntu. Someone else will have to take care of docker.
|
| msg9174 (view) |
Author: jendrik |
Date: 2020-01-17.15:23:19 |
|
Before we merge this, we need to install the new clang-tidy version in our Docker containers.
|
| msg9173 (view) |
Author: jendrik |
Date: 2020-01-17.15:18:00 |
|
I prepared a pull request for this. It uses clang-tidy-8, but we can use a different version if you prefer: https://bitbucket.org/jendrikseipp/downward/pull-requests/150
The new version uncovered some unnecessary copies, which I fixed in the default branch already: https://bitbucket.org/jendrikseipp/downward/commits/51ecb6fb3d49ee6013f150add6180728b2b660e1
|
| msg9172 (view) |
Author: jendrik |
Date: 2020-01-17.13:28:39 |
|
Update summary.
|
| msg9160 (view) |
Author: jendrik |
Date: 2020-01-16.12:54:16 |
|
For now, I'd only change the version.
|
| msg9159 (view) |
Author: malte |
Date: 2020-01-16.12:28:44 |
|
Do you just want to change the version or also enable more tests? If the latter, please tell us which changes to the codebase the new code tests would require.
|
| msg9154 (view) |
Author: jendrik |
Date: 2020-01-16.10:42:42 |
|
We currently use clang-tidy-5.0, which is only available in Ubuntu 16.04 and 18.04. To support newer Ubuntu versions, we need to switch to a newer clang-tidy version. All of clang-tidy 6.0, 7.0 and 8 are viable options (https://packages.ubuntu.com/search?lang=en&keywords=clang-tidy&searchon=names). Version 6.0 has the advantage that it is available on Ubuntu 16.04. The newer versions, on the other hand, offer more code tests (https://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy, https://releases.llvm.org/8.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html#improvements-to-clang-tidy). In my opinion, it would be fine to use clang-tidy-8 since it has a greater chance of being available in coming Ubuntu releases. What are your thoughts?
|
|
| Date |
User |
Action |
Args |
| 2020-01-30 16:24:08 | cedric | set | status: in-progress -> resolved
messages:
+ msg9183
summary: TODO:
* install the new clang-tidy version in our Docker containers
* remove clang-tidy-5 from our Docker containers -> |
| 2020-01-30 14:44:56 | jendrik | set | messages:
+ msg9182 |
| 2020-01-30 14:40:47 | cedric | set | messages:
+ msg9181
summary: TODO:
* install the new clang-tidy version in our Docker containers -> TODO:
* install the new clang-tidy version in our Docker containers
* remove clang-tidy-5 from our Docker containers |
| 2020-01-30 10:47:23 | jendrik | set | status: reviewing -> in-progress
messages:
+ msg9180
summary: TODO:
* decide which clang-tidy version to use
* install the new clang-tidy version in our Docker containers -> TODO:
* install the new clang-tidy version in our Docker containers |
| 2020-01-24 14:25:38 | malte | set | messages:
+ msg9177 |
| 2020-01-17 15:23:19 | jendrik | set | messages:
+ msg9174
summary: TODO:
* decide which clang-tidy version to use -> TODO:
* decide which clang-tidy version to use
* install the new clang-tidy version in our Docker containers |
| 2020-01-17 15:18:01 | jendrik | set | status: chatting -> reviewing
messages:
+ msg9173 |
| 2020-01-17 13:28:39 | jendrik | set | status: deferred -> chatting
messages:
+ msg9172
summary: Blocked by issue955.
TODO:
* merge issue955
* decide which clang-tidy version to use -> TODO:
* decide which clang-tidy version to use |
| 2020-01-16 19:31:50 | jendrik | set | status: chatting -> deferred
summary: Blocked by issue955.
TODO:
* merge issue955
* decide which clang-tidy version to use |
| 2020-01-16 12:54:16 | jendrik | set | assignedto: jendrik
messages:
+ msg9160 |
| 2020-01-16 12:28:44 | malte | set | status: unread -> chatting
messages:
+ msg9159 |
| 2020-01-16 10:51:28 | cedric | set | nosy:
+ cedric |
| 2020-01-16 10:42:43 | jendrik | create | |