Issue965

Title allow creating timers in stopped state
Priority wish Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2020-05-12.08:55:36 by jendrik, last changed by jendrik.

Messages
msg9305 (view) Author: jendrik Date: 2020-05-12.13:10:04
Awesome! I tested it locally, found no errors and merged the branch.
msg9304 (view) Author: malte Date: 2020-05-12.12:54:25
Looks ready to merge to me. Have you tested it (locally), just in case, e.g. with the CEGAR heuristic that now uses initially stopped timers?
msg9302 (view) Author: jendrik Date: 2020-05-12.12:46:21
I agree, we don't necessarily need the assertion and I removed it. Can I merge this?
msg9301 (view) Author: malte Date: 2020-05-12.11:09:12
I had a look. I think the case distinction in the constructor/use of NaN is more complicated than necessary (though I realize you need it if you want the assertion), but in general this looks fine.
msg9300 (view) Author: jendrik Date: 2020-05-12.09:21:43
I prepared a patch at https://bitbucket.org/jendrikseipp/downward/pull-requests/153 . Could you have a look, please?
msg9299 (view) Author: jendrik Date: 2020-05-12.08:55:36
This came up in issue781.
History
Date User Action Args
2020-05-12 13:10:04jendriksetstatus: reviewing -> resolved
messages: + msg9305
2020-05-12 12:54:25maltesetmessages: + msg9304
2020-05-12 12:46:21jendriksetmessages: + msg9302
2020-05-12 11:09:12maltesetmessages: + msg9301
2020-05-12 09:21:43jendriksetstatus: unread -> reviewing
messages: + msg9300
2020-05-12 08:55:36jendrikcreate