Issue1019

Title Split Generation of PDBs from PatternDatabase
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte, silvan, thomas
Assigned To silvan Keywords
Optional summary

Created on 2021-04-29.12:25:44 by silvan, last changed by silvan.

Messages
msg11021 (view) Author: silvan Date: 2023-02-14.17:58:57
Pushed onto main.
msg11012 (view) Author: silvan Date: 2023-02-10.19:09:25
I fixed the problem on Windows. Malte, do you want to review that issue or should I proceed to draft a commit message?
msg10998 (view) Author: silvan Date: 2023-02-09.23:09:55
Experiments finished and look ok (no large changes; the small ones probably due to reaching time limits): https://ai.dmi.unibas.ch/_experiments/ai/downward/issue1019/data/issue1019-v1-eval/issue1019-v1-issue1019-base-issue1019-v1-compare.html
msg10953 (view) Author: silvan Date: 2023-01-30.18:45:42
I restarted this and planned to break the changes up into several small chunks. This issue only moves everything related to computing a PatternDatabase into a new class PatternDatabaseFactory (plus an external function as abbreviation).

Pull request: https://github.com/aibasel/downward/pull/144
msg10260 (view) Author: silvan Date: 2021-04-29.17:05:16
I took the changes which I experimentally made while working on issue1007 and created pull request: https://github.com/aibasel/downward/pull/40/files
This is not very polished yet but should serve as a starting point for discussing the design further.
msg10256 (view) Author: silvan Date: 2021-04-29.12:25:44
Currently, PatternDatabase objects are created from their constructor. This involves computing hash multipliers for hashing states, abstract operators and a match tree for successor (or rather predecessor) generation, and distances for the actual PDB. Separating these steps into individual functions/factory classes has the benefit that one can use these parts independently of computing a PDB. It further allows to hook into the PDB computation to compute any additional information as a side product, without affect the PDB interface. issue1007 shows a use case for this scenario, and two other projects I've recently worked on would benefit from this.
History
Date User Action Args
2023-02-14 17:58:57silvansetstatus: in-progress -> resolved
messages: + msg11021
2023-02-10 19:09:25silvansetmessages: + msg11012
2023-02-09 23:09:55silvansetmessages: + msg10998
2023-01-30 18:45:42silvansetmessages: + msg10953
2021-04-29 17:53:11floriansetnosy: + florian
2021-04-29 17:05:16silvansetstatus: unread -> in-progress
assignedto: silvan
messages: + msg10260
2021-04-29 12:26:28thomassetnosy: + thomas
2021-04-29 12:25:45silvancreate