Issue1043

Title Pattern (collection) generators: move verbosity option to base class; support it in all generators
Priority wish Status resolved
Superseder Nosy List jendrik, malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2022-02-07.14:27:06 by silvan, last changed by silvan.

Messages
msg10603 (view) Author: silvan Date: 2022-02-11.12:48:52
Done.
msg10602 (view) Author: malte Date: 2022-02-11.12:35:24
Yes, I'm happy with seeing this merged.
msg10592 (view) Author: silvan Date: 2022-02-11.08:08:53
I replied to the comment asking about the names and I actually removed the "dump_options" from the log classes. Unless you wanted to reply to the discussion to discuss further, I'll merge this later today.
msg10575 (view) Author: malte Date: 2022-02-10.14:52:25
As discussed on Discord, I've done another review following Patrick's review. I focused on the high-level and design aspects and might have missed details, and I didn't do checks like trying that the output actually makes sense now, that selecting different log levels from the command line does what it should etc.

I had no high-level comments. I liked it all and think the design is now nicely improved. Apart from the review comments this looks ready to merge for me.
msg10531 (view) Author: silvan Date: 2022-02-08.10:47:27
As discussed on Discord, this issue additionally adds support for the verbosity option for all remaining pattern collection generators (hill climbing, genetic, systematic, and manual).
msg10518 (view) Author: silvan Date: 2022-02-07.18:50:58
I created a pull-request: https://github.com/aibasel/downward/pull/91
msg10514 (view) Author: silvan Date: 2022-02-07.14:27:06
While working on issue964, I noticed that most of the pattern (collection) generators use a member verbosity to print who they are and some final statistics. (Some other, more complex generators, also print more output during runtime.) To avoid having a separate logger in each generator, I think each generator (base class) should have one. To prepare this change, in this issue, I want to move the verbosity member to the base classes, change the central generate method to print name and statistics and between call a new virtual "internal generate" method that each derived class has to implement instead of the previous generate method.
History
Date User Action Args
2022-02-11 12:48:52silvansetstatus: reviewing -> resolved
messages: + msg10603
2022-02-11 12:35:24maltesetmessages: + msg10602
2022-02-11 08:08:53silvansetmessages: + msg10592
2022-02-10 14:52:25maltesetmessages: + msg10575
2022-02-08 10:47:27silvansetmessages: + msg10531
title: Pattern (collection) generators: move common logging from derived classes to base class -> Pattern (collection) generators: move verbosity option to base class; support it in all generators
2022-02-07 18:50:58silvansetstatus: in-progress -> reviewing
messages: + msg10518
2022-02-07 14:27:06silvancreate