Title GitHub action Windows 2016 environment is discontinued
Priority bug Status resolved
Superseder Nosy List florian, jendrik, malte, patfer, silvan
Assigned To patfer Keywords
Optional summary

Created on 2022-04-04.09:32:00 by patfer, last changed by patfer.

msg10690 (view) Author: patfer Date: 2022-04-04.14:19:01
Comments are incorporated and the issue is merge.

On some github page the windows version was named as deprecated, but this note is already deprecated as now windows 2016 is not even supported anymore :)
msg10688 (view) Author: malte Date: 2022-04-04.14:04:54
I changed "deprecated" to "discontinued" in the issue title because my understanding was that it's not just a deprecation but instead using the environment causes an error. Maybe I misunderstood. :-)
msg10687 (view) Author: malte Date: 2022-04-04.13:56:19
Thanks, Patrick! I added two comments on github.

Regarding zlib, we discussed offline that we want to continue working with publicly available versions and update our infrastructure when old zlib versions become unavailable. That means our build breaks when this happens, but we see this as good because we want our build to be the guinea pig for other people's builds, who we also want to be able to build with these publicly available versions.
msg10686 (view) Author: patfer Date: 2022-04-04.12:19:14
Here is the PR:

One question came up:
By chance zlib also made a new release (version 1.2.12) and removed the old file (1.2.11) from their homepage. I did not find an archive where we could permanently get a fixed version. If they update again, this will break our actions again. How should we tackle this? Should we upload the zlib files on our own server?
msg10685 (view) Author: malte Date: 2022-04-04.12:16:02
Thanks for taking this on, Patrick!

At minimum, I think getting rid of the Windows 2016 involves the following steps:
- Remove the Windows 2016 stuff from the github actions.
- Update
- Adding a changelog entry explain that and why we got rid of our support for this.

Plus of course the corresponding steps for Windows 2022, if we can add this.

Once we are done removing github's Windows 2016 platfrom from the tested platforms, I suggest we have a discussion with everyone about raising the level of C++ support that we allow ourselves to use.
msg10683 (view) Author: patfer Date: 2022-04-04.09:32:00
The Windows 2016 Environment for GitHub Actions is now deprecated and creates an error instead of running tests.

I try to replace Windows 2016 by the new Windows 2022. If there are issues I'll report them. It would be good to fix them before any user experiences them.
Date User Action Args
2022-04-04 14:19:01patfersetstatus: in-progress -> resolved
messages: + msg10690
2022-04-04 14:04:54maltesetmessages: + msg10688
title: GitHub Action Windows 2016 Environement is Deprecated -> GitHub action Windows 2016 environment is discontinued
2022-04-04 13:56:19maltesetmessages: + msg10687
2022-04-04 12:19:14patfersetmessages: + msg10686
2022-04-04 12:16:02maltesetmessages: + msg10685
2022-04-04 09:32:00patfercreate