Issue1056

Title dump overall time and memory limits
Priority feature Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary
Pull request: https://github.com/aibasel/downward/pull/101

Created on 2022-04-16.19:28:00 by jendrik, last changed by jendrik.

Summary
Pull request: https://github.com/aibasel/downward/pull/101
Messages
msg10704 (view) Author: jendrik Date: 2022-04-21.20:04:52
Merged.
msg10703 (view) Author: malte Date: 2022-04-21.16:06:33
Thanks! Feel free to merge.
msg10702 (view) Author: jendrik Date: 2022-04-21.15:57:48
Good point. I adapted the changelog message.
msg10701 (view) Author: malte Date: 2022-04-21.14:46:34
Looks good to me with one comment: I see in the diff that some functionality is not available on Windows. Mention this in the changelog? Not necessary if this is just moved code rather than new code.
msg10700 (view) Author: jendrik Date: 2022-04-21.13:05:33
Makes sense. In my pull request (see above), I now print the overall planner runtime. Printing peak memory is not as straightforward. Can you have a look at the code, please?
msg10699 (view) Author: malte Date: 2022-04-17.19:22:54
Makes sense to me, but can we combine this with also printing total planner runtime in the same way? To me how much time was actually taken is more basic information than how much time was allowed.

It would be nice to also print the overall peak memory usage, but this would be tougher with the current code, whereas overall time usage should be easy enough, right? I assume the driver already needs to know this in order to set the timeouts for the processes it calls. If we can also make overall peak memory usage work, even better.
msg10698 (view) Author: jendrik Date: 2022-04-16.19:28:00
In order to compute scores for planner_time and planner_memory with Downward Lab, I propose to let the driver output the overall time and memory limits. The limits are needed as upper bounds for computing the logarithmic scores. Here is the proposed output format:


INFO     planner time limit: 22s
INFO     planner memory limit: 100 MB

INFO     Running translator.
INFO     translator stdin: None
INFO     translator time limit: 21.96s
INFO     translator memory limit: 100 MB
...


Thoughts?
History
Date User Action Args
2022-04-21 20:04:52jendriksetstatus: reviewing -> resolved
messages: + msg10704
2022-04-21 16:06:33maltesetmessages: + msg10703
2022-04-21 15:57:48jendriksetmessages: + msg10702
2022-04-21 14:46:34maltesetmessages: + msg10701
2022-04-21 13:05:33jendriksetstatus: chatting -> reviewing
assignedto: jendrik
messages: + msg10700
summary: Pull request: https://github.com/aibasel/downward/pull/101
2022-04-17 19:22:54maltesetstatus: unread -> chatting
messages: + msg10699
2022-04-16 19:28:00jendrikcreate