I left some comments on Github. I think the changes done to the code by the newer version are all positive, but we should fix the old hacks that are affected. I'm somewhat on the fence about whether uncrustify should introduce things that go beyond reformatting the code, like static_cast.
How would the wiki page change? Are the installation instructions still working in the same way for the new version? Is it working on all systems we want to support (I remember getting the right uncrustify version used to be tricky)?
Is there anything else that has to be changed besides the Github actions, Wiki, and code?
|