Issues Show Unassigned Show All Search
Login Remember me? Register Lost your login?
Help Roundup docs
Created on 2023-07-25.16:37:54 by florian, last changed by florian.
In issue565 we identified some cases where our code currently shadows either global variables, member variables, or other local variables. Here, we want to deal with these cases. Shadowing isn't necessarily a problem, so one way of dealing with a case can also be to accept it as is. Here is a list of cases from msg11182 and msg11181: State::num_variables https://github.com/aibasel/downward/blob/main/src/search/task_proxy.h#L781 pdbs::PatternCollectionGeneratorMultiple::max_pdb_size pdbs::PatternCollectionGeneratorMultiple::rng https://github.com/aibasel/downward/blob/main/src/search/pdbs/pattern_collection_generator_multiple_random.cc#L33 https://github.com/aibasel/downward/blob/main/src/search/pdbs/pattern_collection_generator_multiple_cegar.cc#L24 merge_and_shrink::MergeTreeNode::parent https://github.com/aibasel/downward/blob/main/src/search/merge_and_shrink/merge_tree.cc#L91 cegar::Node::var cegar::Node::value cegar::Node::left_child cegar::Node::right_child cegar::Node::value https://github.com/aibasel/downward/blob/main/src/search/cegar/refinement_hierarchy.h#L86 https://github.com/aibasel/downward/blob/main/src/search/cegar/refinement_hierarchy.cc#L30 cg_heuristic::CGCache::depends_on https://github.com/aibasel/downward/blob/main/src/search/heuristics/cg_cache.cc#L78 enforced_hill_climbing_search::EnforcedHillClimbingSearch::evaluator https://github.com/aibasel/downward/blob/main/src/search/search_engines/enforced_hill_climbing_search.cc#L84 https://github.com/aibasel/downward/blob/main/src/search/search_engines/enforced_hill_climbing_search.cc#L100 PruningMethod::task https://github.com/aibasel/downward/blob/main/src/search/pruning/stubborn_sets_ec.cc#L109 https://github.com/aibasel/downward/blob/main/src/search/pruning/stubborn_sets_simple.cc#L14 https://github.com/aibasel/downward/blob/main/src/search/pruning/stubborn_sets_atom_centric.cc#L18 https://github.com/aibasel/downward/blob/main/src/search/pruning/limited_pruning.cc#L19 https://github.com/aibasel/downward/blob/main/src/search/pruning/stubborn_sets.cc#L14 https://github.com/aibasel/downward/blob/main/src/search/pruning/null_pruning_method.cc#L13 plugins::RawRegistry::subcategory_plugins https://github.com/aibasel/downward/blob/main/src/search/plugins/raw_registry.cc#L119 https://github.com/aibasel/downward/blob/main/src/search/plugins/raw_registry.cc#L182 plugins::Feature::subcategory plugins::Feature::title plugins::CategoryPlugin::synopsis plugins::SubcategoryPlugin::title https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L12 https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L16 https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L106 https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L119 https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L123 SearchEngine::plan https://github.com/aibasel/downward/blob/main/src/search/plugins/plugin.cc#L119 https://github.com/aibasel/downward/blob/main/src/search/heuristics/domain_transition_graph.cc#L96 (origin) https://github.com/aibasel/downward/blob/main/src/search/landmarks/landmark_factory_h_m.cc#L370 (pm_fluent) https://github.com/aibasel/downward/blob/main/src/search/parser/abstract_syntax_tree.cc#L276 (block) Variables called 'relation', 'predicate', and 'equivalence_relation'.