I didn't mention clang in the lists for Ubuntu and g++-13 is actually not available via apt on 22.04:
* corrected versions for GCC and Clang on Ubuntu:
- should be g++-12, clang-15 (from 22.04) and g++14, clang-18 (from 24.04)
I found four kinds of problems with the new compilers:
1) A new warning came up with (Apple) clang >=15. I disabled it for now because I'm not sure if we want to change this:
error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
preferred_operators = move(preferred_ops);
^
std::
2) There were also some legit cases of warnings that older compilers didn't recognize. I fixed those.
* unused variables in loops that were write-only
* missing call to vector::reserve() before a loop of push_backs
* std::string variable were a const reference would be enough.
* complicated logic in if-statement that could be simplified with De Morgan's rules.
3) Our version of SoPlex doesn't compile anymore because it has an invalid assignment of an array. This is fixed in newer versions of Soplex but that would mean we have to upgrade the version of Soplex as well. We wanted to do this anyway when other fixes we are relying on were officially released. So far, we were using a specific commit that wasn't merged into the release branch back then. By now, the current releases merged this, so we could use them instead and avoid some special casing in the build instructions. But this will likely need experiments to evaluate the performance of the new version.
4) clang-tidy-12 was used for our style tests but is no longer available on ubuntu 24.04. Versions 14 and 15 are available on both LTS (22.04/24.04), but can cause a bug with clang in the Github actions similar to what we saw with clang-12. For clang-12 we had a workaround in the workflow but this doesn't work for clang-tidy-15. I suggest we use clang-tidy-16 which can be installed on 24.04 through apt and on 22.04 as a manual installation (https://askubuntu.com/questions/1473403/how-to-install-clang-16-on-22-04-lts).
|