Issue1151

Title No parse error when missing or incorrect search algorithm, just heuristic
Priority bug Status resolved
Superseder Nosy List florian, jendrik, malte, silvan
Assigned To Keywords
Optional summary
PR: https://github.com/aibasel/downward/pull/234

Created on 2024-09-13.15:28:52 by mpozo, last changed by florian.

Summary
PR: https://github.com/aibasel/downward/pull/234
Messages
msg11706 (view) Author: florian Date: 2024-10-07.14:45:29
We merged the PR.
msg11697 (view) Author: florian Date: 2024-09-27.15:46:02
I added an error message as a pull request.
msg11692 (view) Author: florian Date: 2024-09-13.15:34:11
As discussed on Discord, this happens if the command-line parses correctly but has the wrong type. The fix would be to add error handling to this line:
https://github.com/aibasel/downward/blob/main/src/search/command_line.cc#L106
msg11691 (view) Author: florian Date: 2024-09-13.15:33:03
I moved the summary to the discussion (we use the summary field to track information about the current status and links to pull requests, etc.)

Original message:
-----------------
Bad `AnyCast` error on `SearchAlgorithm` instead of reporting an error in the command before starting to compute the heuristic when a search algorithm is missing. Examples:

/fast-downward.py --search --translate ../autoscale-benchmarks/21.11-optimal-strips/transport/domain.pddl ../autoscale-benchmarks/21.11-optimal-strips/transport/p01.pddl --search "cegar()" > transport01.out 2>&1

./builds/release/bin/downward --search "cegar()" < transport08_preprocessed.sas > transport08.out 2>&1
History
Date User Action Args
2024-10-07 14:45:29floriansetstatus: chatting -> resolved
messages: + msg11706
2024-09-27 15:46:02floriansetmessages: + msg11697
summary: PR: https://github.com/aibasel/downward/pull/234
2024-09-13 15:34:11floriansetmessages: + msg11692
2024-09-13 15:33:03floriansetnosy: + malte, jendrik, silvan, florian
messages: + msg11691
summary: Bad `AnyCast` error on `SearchAlgorithm` instead of reporting an error in the command before starting to compute the heuristic when a search algorithm is missing. Examples: /fast-downward.py --search --translate ../autoscale-benchmarks/21.11-optimal-strips/transport/domain.pddl ../autoscale-benchmarks/21.11-optimal-strips/transport/p01.pddl --search "cegar()" > transport01.out 2>&1 ./builds/release/bin/downward --search "cegar()" < transport08_preprocessed.sas > transport08.out 2>&1 -> (no value)
2024-09-13 15:28:52mpozocreate