Issue201

Title wrong logic in iterated search
Priority bug Status resolved
Superseder Nosy List erez, malte
Assigned To erez Keywords
Optional summary

Created on 2011-01-07.14:07:09 by malte, last changed by malte.

Messages
msg1148 (view) Author: malte Date: 2011-01-11.20:33:47
Merged.
msg1124 (view) Author: erez Date: 2011-01-09.09:52:36
Fixed and pushed.
On a side note - it turns out that the return value of step() from the main 
search is never checked (the only value that matters is IN_PROGRESS. Once it 
finishes, nobody checks if it SOLVED or FAILED).
msg1106 (view) Author: malte Date: 2011-01-07.14:07:08
This logic looks wrong:

int IteratedSearch::step() {
    current_search = create_phase(phase);
    if (current_search == NULL) {
        return (last_phase_found_solution) ? SOLVED : FAILED;
    }
    ...
}

What if the last phase didn't find a solution but a previous one did? Then the
iterated search overall did find a solution. This should return SOLVED iff any
plan was found.
History
Date User Action Args
2011-01-11 20:33:47maltesetstatus: reviewing -> resolved
messages: + msg1148
2011-01-11 20:03:10erezsetstatus: chatting -> reviewing
2011-01-09 09:52:36erezsetmessages: + msg1124
2011-01-07 14:07:09maltecreate