Issue284

Title passing double through int in ipdb implementation
Priority bug Status resolved
Superseder Nosy List malte, patrik, silvan
Assigned To silvan Keywords
Optional summary

Created on 2011-10-04.10:50:53 by patrik, last changed by malte.

Messages
msg1805 (view) Author: malte Date: 2011-10-13.19:33:07
Fixed in the main repository now, too. Thanks for reporting!
msg1804 (view) Author: patrik Date: 2011-10-05.16:10:06
No problem, I've already fixed my copy (and now I get more interesting results;
maybe not better, but more interesting ;))
msg1803 (view) Author: malte Date: 2011-10-05.15:47:41
Let's use this to get some useful practice with the workflow once I'm back from
the conference. Patrik: we'll fix this next week.
msg1802 (view) Author: silvan Date: 2011-10-05.15:37:31
It is as simple as Patrik wrote, one just needs to change the paramater of the
hill_climbing method to be a double instead of an integer.
Malte, I sent you an email asking you something regargind the teamproject's
repository. So when you answered, I'll either fix the bug by then so you can
merge it or you can just directly change it in the master repository yourself
(it's just the two lines of code).
msg1801 (view) Author: silvan Date: 2011-10-04.16:50:19
I'll check it later today or at least tomorrow.
msg1800 (view) Author: malte Date: 2011-10-04.15:58:27
Silvan, can you look into this?
msg1799 (view) Author: patrik Date: 2011-10-04.10:50:53
Found a bug in the iPDB implementation
(search/pdbs/pattern_generation_haslum.h/.cc):

The average cost over all operators (named average_operator_cost throughout) is
computed in the initialize() method, which passes it to the hill_climbing
method, which passes it on to sample_states, where it is used to compute an
estimate of plan length. The average is (of course) represented by a double,
everywhere except in the parameter to the hill_climbing method. This means the
average gets rounded down when it's passed through hill_climbing, which means
that when it is < 1, the value that reaches sample_states is 0, which has
undesirable consequences.
History
Date User Action Args
2011-10-13 19:33:08maltesetstatus: chatting -> resolved
messages: + msg1805
2011-10-05 16:10:06patriksetmessages: + msg1804
2011-10-05 15:47:41maltesetmessages: + msg1803
2011-10-05 15:37:31silvansetmessages: + msg1802
2011-10-04 16:50:19silvansetmessages: + msg1801
2011-10-04 15:58:27maltesetstatus: unread -> chatting
nosy: + silvan
messages: + msg1800
assignedto: silvan
2011-10-04 10:50:53patrikcreate