Title better error messages for illegal or unsupported types
Priority bug Status chatting
Superseder Nosy List malte, rpgoldman, ukuter
Assigned To malte Keywords
Optional summary

Created on 2012-02-16.16:56:18 by rpgoldman, last changed by malte.

File name Uploaded Type Edit Remove
proba31456134848211.pddl rpgoldman, 2012-02-16.16:57:26 application/octet-stream
trap.pddl rpgoldman, 2012-02-16.16:57:50 application/octet-stream
msg2065 (view) Author: malte Date: 2012-02-16.20:34:37
That's because types within predicate definitions are ignored -- you can write
"(at ?x - (foo (((bar) baz bla))) ?y - (or (not (and ?x :action foo))))" and I
think the planner would accept it.

Unfortunately, there is no authoritative semantics for type annotations in the
:predicates block and no two people I've talked to have given the same opinion
on what the semantics should be...

We can tighten that, too, and only allow declared :types in the predicate type
msg2064 (view) Author: rpgoldman Date: 2012-02-16.17:22:12
What's funny here is that sometimes EITHER is benign (e.g., if the EITHER is in a 
predicate type declaration), or at least fails quietly.
msg2063 (view) Author: malte Date: 2012-02-16.17:18:41
Hi Robert, "either" is generally not supported (see The translator doesn't
even know that "either" is a keyword -- you would get the same error message if

(exists (?E - (either c_human c_exploit))
                    (controls_proc ?E ?P))

were replaced by

(exists (?E - (foobar c_human c_exploit))
                    (controls_proc ?E ?P))

The problem here (as in so many places) is lack of clear error reporting. The
parser expects that the thing after "?E - " -- in this case "(foobar c_human
c_exploit)" is an atomic name. Instead, it is a list. The translator doesn't
actually check that the thing it sees is an atomic name, but just happily
proceeds assuming that it is a valid typename. Later on, it tries to put this
typename into a dictionary, which it cannot, since lists (such as "(foobar
c_human c_explit)") are not hashable.

I'll look into improving the reporting here.
msg2062 (view) Author: rpgoldman Date: 2012-02-16.17:10:12
Related to 298.
msg2061 (view) Author: rpgoldman Date: 2012-02-16.17:06:16
Ah.  Got through that, and there's the same bug in an effects expression with a 
UNIVERSALLY quantified EFFECT that has an EITHER type.

Again, can be rewritten into a conjunction of simply-typed quantified effects.
msg2060 (view) Author: rpgoldman Date: 2012-02-16.16:56:17
The translator seems to fail on this precondition subexpression:
(exists (?E - (either c_human c_exploit))
                    (controls_proc ?E ?P))
The same either expression works elsewhere, but fails in; can't 
compute a hash function for (either c_human c_exploit).

I will attach domain and problem file.

Note that it's not impossible to rewrite the either to two separate 
existentials, so a bug, but not critical.

Traceback (most recent call last):
  File "/Users/rpg/src/fast-downward/src//translate/", line 570, in 
    task =
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 47, 
in open
    return tasks.Task.parse(domain_pddl, task_pddl)
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 40, in 
    = parse_domain(domain_pddl)
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 160, in 
    action = actions.Action.parse(entry)
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 38, in 
    precondition = conditions.parse_condition(
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 5, 
in parse_condition
    condition = parse_condition_aux(alist, False)
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 37, 
in parse_condition_aux
    parts = [parse_condition_aux(part, negated) for part in args]
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 46, 
in parse_condition_aux
    return ExistentialCondition(parameters, parts)
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 
209, in __init__
    self.hash = hash((self.__class__, self.parameters,
  File "/Users/rpg/src/fast-downward/src/translate/pddl/", line 38, 
in __hash__
    hashval = hash((, self.type))
TypeError: unhashable type: 'list'
Date User Action Args
2012-02-17 13:51:34maltesettitle: Fast Downward fails to parse existential with EITHER type -> better error messages for illegal or unsupported types
2012-02-16 20:34:38maltesetmessages: + msg2065
2012-02-16 17:22:12rpgoldmansetmessages: + msg2064
2012-02-16 17:18:41maltesetassignedto: malte
messages: + msg2063
2012-02-16 17:10:12rpgoldmansetmessages: + msg2062
2012-02-16 17:06:16rpgoldmansetstatus: unread -> chatting
messages: + msg2061
2012-02-16 16:57:50rpgoldmansetfiles: + trap.pddl
2012-02-16 16:57:26rpgoldmansetfiles: + proba31456134848211.pddl
2012-02-16 16:56:18rpgoldmancreate