Issue461

Title rename global classes
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2014-08-29.12:33:49 by jendrik, last changed by jendrik.

Messages
msg3438 (view) Author: jendrik Date: 2014-09-17.22:09:43
Merged and pushed.
msg3437 (view) Author: malte Date: 2014-09-17.20:40:53
Please merge.
msg3436 (view) Author: jendrik Date: 2014-09-17.20:36:46
Florian had a look at the pull-request [1] and is fine with the changes. Can I 
merge this?

[1] https://bitbucket.org/jendrikseipp/downward/pull-request/19/issue461-rename-
global-classes/diff
msg3386 (view) Author: malte Date: 2014-08-29.14:35:23
I think we should leave the state registry system unaffected, at least for now.
It only interfaces with a small part of the code.
msg3385 (view) Author: jendrik Date: 2014-08-29.14:32:35
What about StateID and StateRegistry?
msg3384 (view) Author: malte Date: 2014-08-29.14:32:18
Would make sense. This would also mean resorting the relevant #includes.
msg3383 (view) Author: jendrik Date: 2014-08-29.14:31:16
I guess we also want to rename the filenames and include guards, right?

operator.h -> global_operator.h
state.h -> global_state.h
msg3380 (view) Author: malte Date: 2014-08-29.13:35:44
Given that our states are always states of the global task, I think I'm in
favour of the renaming. I only see part of where this whole task class journey
is going at the moment, though. I expect that at the end these classes will
converge again to some extent (with the global task not being particularly
special), but even then I think it's good to rename the current state class for
now so that it won't be mistaken for something it isn't (a generic state class
applicable to all kinds of tasks).
msg3379 (view) Author: jendrik Date: 2014-08-29.13:33:07
I'd say we wait with renaming the State class until we're sure we need it, but I 
could also do it now if you prefer. What do you think?
msg3377 (view) Author: malte Date: 2014-08-29.13:07:41
We also discussed the possible renaming State -> GlobalState.

At this point, I'm not sure if it is going to be necessary, but I think it's
more likely than not.

(As Gabi mentioned, I'd recommend doing this one with an IDE -- much less work.)
msg3376 (view) Author: jendrik Date: 2014-08-29.12:33:49
As discussed offline we need to rename some classes before we can merge issue439 
(task class). The proposed renamings are:

Operator -> GlobalOperator
Effect -> GlobalEffect
Condition -> GlobalCondition
History
Date User Action Args
2014-09-17 22:09:43jendriksetstatus: chatting -> resolved
messages: + msg3438
2014-09-17 20:40:53maltesetmessages: + msg3437
2014-09-17 20:36:46jendriksetnosy: + florian
messages: + msg3436
2014-08-29 14:35:23maltesetmessages: + msg3386
2014-08-29 14:32:35jendriksetmessages: + msg3385
2014-08-29 14:32:18maltesetmessages: + msg3384
2014-08-29 14:31:16jendriksetmessages: + msg3383
2014-08-29 13:35:44maltesetmessages: + msg3380
2014-08-29 13:33:07jendriksetmessages: + msg3379
2014-08-29 13:07:41maltesetstatus: unread -> chatting
messages: + msg3377
2014-08-29 12:33:49jendrikcreate