Issue528

Title Use new task interface in LM-cut
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To florian Keywords
Optional summary

Created on 2015-05-05.14:56:12 by florian, last changed by florian.

Messages
msg4200 (view) Author: florian Date: 2015-05-13.14:25:50
Merged. Thanks again.
msg4199 (view) Author: jendrik Date: 2015-05-13.13:25:06
I think the code can be merged.
msg4198 (view) Author: malte Date: 2015-05-13.13:18:55
Please merge it once you both like it. (If you don't think it's necessary, I
won't look at the code or detailed results.)
msg4193 (view) Author: florian Date: 2015-05-13.01:48:42
Forgot to add a link to the latest report:

http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528-base-issue528-v3-compare.html
msg4192 (view) Author: florian Date: 2015-05-13.01:47:50
Thanks Jendrik! I included your suggestions and ran the experiment again. One
node on the grid crashed during the experiment (ase08) so there are 14 runs that
did not finish. The remaining runs confirm the results from the last experiment:
the patched version is about 10% faster than the baseline and solves 5
additional tasks.

Can I merge this?
msg4189 (view) Author: jendrik Date: 2015-05-12.12:33:50
Done with the review.
msg4187 (view) Author: jendrik Date: 2015-05-11.21:47:00
Yes, I will do a review.
msg4186 (view) Author: florian Date: 2015-05-11.20:37:52
I forgot to create a pull request on bitbucket, so we can comment on the code.
Here it is:

https://bitbucket.org/flogo/downward-issues-issue528/pull-request/1/issue528/diff
msg4185 (view) Author: florian Date: 2015-05-11.20:34:10
I have a patch ready for review at
https://bitbucket.org/flogo/downward-issues-issue528/branch/issue528#diff

The branch has 2 main commits: the first (v1) changes LM-cut to use the task
interface and the second (v2) does some drive-by cleanup and changes for loops
in LM-cut to range-based loops.

I ran experiments for both versions and the results look good (+5 coverage):

Base -> v1
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528-base-issue528-v1-compare.html
v1 -> v2
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528-v1-issue528-v2-compare.html
Base -> v2
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528-base-issue528-v2-compare.html
Scatter plots for memory and time:
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528_base_v2_total_time.png
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue528_base_v2_memory.png

Jendrik, could you do a review?
msg4181 (view) Author: florian Date: 2015-05-05.14:56:12
LM-cut should use the task it get from the options object (as a TaskProxy)
instead of the global task.

Once this is done, we can continue with issue527.
History
Date User Action Args
2015-05-13 14:25:50floriansetstatus: reviewing -> resolved
messages: + msg4200
2015-05-13 13:25:06jendriksetmessages: + msg4199
2015-05-13 13:18:55maltesetmessages: + msg4198
2015-05-13 01:48:42floriansetmessages: + msg4193
2015-05-13 01:47:50floriansetstatus: in-progress -> reviewing
messages: + msg4192
2015-05-12 12:33:50jendriksetstatus: reviewing -> in-progress
messages: + msg4189
2015-05-11 21:47:00jendriksetstatus: in-progress -> reviewing
messages: + msg4187
2015-05-11 20:37:52floriansetmessages: + msg4186
2015-05-11 20:34:10floriansetstatus: unread -> in-progress
messages: + msg4185
2015-05-05 14:56:12floriancreate