Issue568

Title non-deterministic preprocessor output
Priority bug Status resolved
Superseder Nosy List gabi, malte, salome, silvan
Assigned To Keywords
Optional summary

Created on 2015-07-27.12:17:42 by salome, last changed by malte.

Files
File name Uploaded Type Edit Remove
output_v1 salome, 2015-07-27.12:18:40 application/octet-stream
output_v2 salome, 2015-07-27.12:18:49 application/octet-stream
Messages
msg5025 (view) Author: malte Date: 2016-01-05.17:39:45
I suggest to close this one (and am doing it now, but feel free to change again
if you prefer) because the DTG produced by the preprocessor doesn't affect the
search any more.

Regarding changing the preprocessor output format, I have no strong opinion
whether to do it now or later. Whatever you prefer.
msg5017 (view) Author: gabi Date: 2016-01-05.15:45:56
Since the DTGs from the prepropressor output are no longer used by the search
component, should we simply close this issue? Or should we first get rid of the
DTGs in the preprocessor output (issue26), which actually would be a five-minute
task (mainly updating the documentation)?
msg4495 (view) Author: malte Date: 2015-07-27.19:17:56
Neither issue434 nor this one has someone assigned to it. Anyone want to take
this on? If not, I can see if I can look into this.
msg4492 (view) Author: malte Date: 2015-07-27.14:00:51
Yes, I think we can close one of the two issues and add a pointer to the other one.

In the old issue, we mentioned the option to fix this at the same time as moving
the DTG generation into the search component, but in terms of running
experiments that we can easily analyze, it's perhaps better to fix it in the
preprocessor first (checking if that leads to a performance regression) and only
then migrate the code to the search component. That way, if performance is hurt,
we'll be able to assess whether it's because of the change to the DTGs or due to
the fact that they're computed in the search component.
msg4491 (view) Author: silvan Date: 2015-07-27.12:24:24
(Adding Malte since I think that he should always be on the nosy list at least.)
msg4490 (view) Author: silvan Date: 2015-07-27.12:23:45
No problem, so we can just close the old issue and refer to this new one.
msg4489 (view) Author: salome Date: 2015-07-27.12:22:48
Indeed this seems to be the exact same problem. Sorry, I was unaware this issue
existed already.
msg4487 (view) Author: silvan Date: 2015-07-27.12:19:16
I think this issue is related (or even the same problem?): issue434
msg4486 (view) Author: salome Date: 2015-07-27.12:17:41
The description of the DTG in the preprocessor output is not always the same for
the same problem. Attached are two possible outputs for the problem
depot/pfile16. As far as I can tell the described DTG is the same but the
ordering of the transitions and transition conditions are different.
The problem seems to be very hard to reproduce (across 6 different repository
locations on 3 different machines i only had a different output in 1
repository), however I assume that the problem is the sorting of the vertices
vector in DomainTransitionGraph::finalize(). vertices is a
vector<vector<Transition> >, and the less-operator of Transition only compares
target, condition size and cost (if all 3 are equal, it is not defined which one
is smaller).
History
Date User Action Args
2016-01-05 17:39:45maltesetstatus: chatting -> resolved
messages: + msg5025
2016-01-05 15:45:56gabisetnosy: + gabi
messages: + msg5017
2015-07-27 19:17:56maltesetmessages: + msg4495
2015-07-27 14:00:51maltesetmessages: + msg4492
2015-07-27 12:24:24silvansetnosy: + malte
messages: + msg4491
2015-07-27 12:23:45silvansetstatus: unread -> chatting
messages: + msg4490
2015-07-27 12:22:48salomesetstatus: chatting -> unread
messages: + msg4489
2015-07-27 12:19:16silvansetstatus: unread -> chatting
nosy: + silvan
messages: + msg4487
2015-07-27 12:18:49salomesetfiles: + output_v2
2015-07-27 12:18:40salomesetfiles: + output_v1
2015-07-27 12:17:42salomecreate