Issue593

Title Uncrustify script fails with mercurial 3.4
Priority bug Status resolved
Superseder Nosy List florian, malte
Assigned To florian Keywords
Optional summary

Created on 2015-11-10.18:43:17 by florian, last changed by malte.

Messages
msg4766 (view) Author: malte Date: 2015-11-10.19:08:31
Seems to work fine at least on my desktop at home. :-) (Ubuntu 15.04, Mercurial
3.1 -- the other machines I'm using don't currently have a usable uncrustify setup.)

Thanks! :-)
msg4765 (view) Author: florian Date: 2015-11-10.19:05:50
Sounds good. Merged.
msg4764 (view) Author: malte Date: 2015-11-10.19:03:34
If you think it's likely to work fine, let's just merge. We can revisit this if
we face problems.
msg4763 (view) Author: florian Date: 2015-11-10.19:01:37
As far as I can tell from https://www.mercurial-scm.org/wiki/ApiChanges there
has been only one change to the signature of status() and no change to the
return value. I looked through some old revisions and it looks like the
signature was like this since the method was introduced.

I created a pull request for this if you want to test it:
https://bitbucket.org/flogo/downward-issues/pull-requests/4/issue593/diff
msg4762 (view) Author: malte Date: 2015-11-10.18:43:47
Will this work with older Mercurial versions?
msg4761 (view) Author: florian Date: 2015-11-10.18:43:17
The mercurial API removed the methods clean(), ignored(), and unknown() that we
accessed in the script: https://selenic.com/hg/rev/76320e2ed0a8

We call the method status() first that prepares the list of files which the
methods then access. The return value of status already contains all the
information we need, so I suggest to just use the return value instead.
History
Date User Action Args
2015-11-10 19:08:31maltesetmessages: + msg4766
2015-11-10 19:05:50floriansetstatus: chatting -> resolved
messages: + msg4765
2015-11-10 19:03:34maltesetmessages: + msg4764
2015-11-10 19:01:37floriansetmessages: + msg4763
2015-11-10 18:43:47maltesetstatus: unread -> chatting
messages: + msg4762
2015-11-10 18:43:17floriancreate