Issue621

Title use Fact struct in task interface
Priority feature Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To jendrik Keywords
Optional summary

Created on 2016-01-08.16:44:47 by jendrik, last changed by jendrik.

Messages
msg5174 (view) Author: jendrik Date: 2016-02-09.14:27:06
Merged and pushed. issue635 deals with using the Fact struct in the remaining 
places.
msg5171 (view) Author: jendrik Date: 2016-02-09.10:51:54
Here is the plot: http://ai.cs.unibas.ch/_tmp_files/seipp/issue621-v1-total_time-cegar-10K-original.png

It seems that the CEGAR code has very nondeterministic runtimes.
msg5169 (view) Author: florian Date: 2016-02-08.19:29:41
Fine with me. One thing I noticed was that the total times for the CEGAR configs
can be very noisy (e.g., airport/p09: 15s vs. 19s, airport/p17: 398s vs. 364s).
This seems to be in both directions and cancels out more or less overall. I
don't think this is caused by this issue, so this should not be an argument
against merging. I would be interested in a relative scatter plot, though, to
compare against the noise we saw in issue627.
msg5168 (view) Author: jendrik Date: 2016-02-08.19:18:12
Thanks for the review! I ran an experiment. Here are the results:

http://ai.cs.unibas.ch/_tmp_files/seipp/issue621-v1-issue621-base-issue621-v1-compare.html

Nothing surprising as far as I can see. Do you think we can merge this, Florian?
msg5154 (view) Author: jendrik Date: 2016-02-05.15:49:08
I made a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/42 

Florian, do you think this can be merged?
msg5082 (view) Author: jendrik Date: 2016-01-12.13:40:43
The POR code will introduce the Fact struct (issue499). Therefore, this issue 
could be concerned with using the Fact struct in search/tasks/, task_proxy.h and 
abstract_task.h.
msg5052 (view) Author: jendrik Date: 2016-01-08.16:44:47
We want to add a Fact struct with two int members "var" and "value" to 
abstract_task.h to produce more self-documenting code.
History
Date User Action Args
2016-02-09 14:27:06jendriksetstatus: reviewing -> resolved
messages: + msg5174
2016-02-09 10:51:54jendriksetmessages: + msg5171
2016-02-08 19:29:41floriansetmessages: + msg5169
2016-02-08 19:18:12jendriksetmessages: + msg5168
2016-02-08 13:45:08jendriksettitle: use Fact struct -> use Fact struct in task interface
2016-02-05 15:49:08jendriksetstatus: deferred -> reviewing
messages: + msg5154
2016-02-05 14:01:01jendriksetassignedto: jendrik
2016-01-12 13:40:43jendriksetstatus: unread -> deferred
messages: + msg5082
title: add Fact struct -> use Fact struct
2016-01-08 17:02:29floriansetnosy: + florian
2016-01-08 16:44:47jendrikcreate