Issue656

Title Integrate tie-breaking options for MergeDFP
Priority feature Status resolved
Superseder Nosy List malte, silvan
Assigned To silvan Keywords
Optional summary

Created on 2016-05-11.14:11:30 by silvan, last changed by silvan.

Messages
msg5370 (view) Author: silvan Date: 2016-05-13.15:17:23
Merged.
msg5368 (view) Author: malte Date: 2016-05-13.11:43:04
Works for me. :-)
msg5367 (view) Author: silvan Date: 2016-05-13.11:10:35
Experiments used for the paper:
http://ai.cs.unibas.ch/_tmp_files/sieverss/2016-02-24-dfp-abs.html

Experiments from this issue branch:
http://ai.cs.unibas.ch/_tmp_files/sieverss/issue656-v1-new-configs.html

Comparing coverage, we never lose a task, and we gain a few for some configurations.
msg5365 (view) Author: silvan Date: 2016-05-12.16:32:52
The behavior of "default" DFP did not change:

http://ai.cs.unibas.ch/_tmp_files/sieverss/issue656-v1-issue656-base-issue656-v1-compare.html

(Experiments to confirm the results from the paper are still ongoing.)
msg5362 (view) Author: silvan Date: 2016-05-12.15:31:28
Ok then. I am very sure to do nothing wrong here, because the change only
affects MergeDFP (and has much less impact than the change from issue655, which
changed the interface of shrink strategies). Furthermore, with issue644
(re-design of merge strategies), this class will no longer exist in this form
anyway. So it will probably be better if you have some energy left over for
having a look at issue644 when it comes to code reviewing :-)
msg5361 (view) Author: malte Date: 2016-05-12.15:20:03
OK, I can't find the energy to look at it in much detail, so I'll just assume
that you know what you're doing. :-) From my side, feel free to merge.
msg5339 (view) Author: silvan Date: 2016-05-11.17:51:45
There it is: https://bitbucket.org/SilvanS/fd-dev/pull-requests/15/issue656/diff
msg5338 (view) Author: silvan Date: 2016-05-11.16:05:16
As soon as I extracted the required changes to an issue branch (not done yet).
msg5337 (view) Author: malte Date: 2016-05-11.16:04:40
Do you have a link for a pull request (or other viewable diff)?
msg5336 (view) Author: silvan Date: 2016-05-11.14:11:30
I'd like to merge the changes that add the "ordering of transition systems"
options (ICAPS 16 paper) to the DFP merge strategy. The code change is small,
and integrating this before starting to work on the huge refactoring of merge
strategies (issue644) would allow to make sure that the behavior of these
options remains the same when changing MergeDFP to use scoring functions.
History
Date User Action Args
2016-05-13 15:17:23silvansetstatus: in-progress -> resolved
messages: + msg5370
2016-05-13 11:43:04maltesetmessages: + msg5368
2016-05-13 11:10:35silvansetmessages: + msg5367
2016-05-12 16:32:52silvansetmessages: + msg5365
2016-05-12 15:31:28silvansetmessages: + msg5362
2016-05-12 15:20:03maltesetmessages: + msg5361
2016-05-11 17:51:46silvansetstatus: chatting -> in-progress
messages: + msg5339
2016-05-11 16:05:16silvansetmessages: + msg5338
2016-05-11 16:04:40maltesetstatus: unread -> chatting
messages: + msg5337
2016-05-11 14:11:30silvancreate