Issue664

Issues
Show Unassigned
Show All
Search

Login




Register
Lost your login?

Help
Roundup docs

Title remove "std::" from cc files
Priority wish Status resolved
Superseder Nosy List jendrik, malte
Assigned To jendrik Keywords
Optional summary 


















Created on 2016-08-04.21:34:13 by jendrik, last changed  by jendrik.








 
Messages

 
  

   msg5490 (view)
   Author: jendrik
   Date: 2016-08-05.19:07:27
   
    
   
  

  

   
    
Thanks! Merged and pushed.

   		
  

 
 
  

   msg5489 (view)
   Author: malte
   Date: 2016-08-05.12:11:03
   
    
   
  

  

   
    
I had a quick look. Feel free to merge.

   		
  

 
 
  

   msg5488 (view)
   Author: jendrik
   Date: 2016-08-04.21:45:44
   
    
   
  

  

   
    
I created a pull request at 
https://bitbucket.org/jendrikseipp/downward/pull-requests/55

Do you think this needs reviewing?

   		
  

 
 
  

   msg5487 (view)
   Author: malte
   Date: 2016-08-04.21:40:48
   
    
   
  

  

   
    
I don't feel strongly either way about this.

   		
  

 
 
  

   msg5486 (view)
   Author: jendrik
   Date: 2016-08-04.21:34:13
   
    
   
  

  

   
    
Remove "std::" from cc files and add style check that fails if new code breaks 
this convention.

I'd be happy to remove the check if you think we should support typing e.g. 
"std::find" in case of ambiguities, but I think it would be better to rename 
our functions etc. in these cases.

   		
  

 





History


Date
User
Action
Args



2016-08-05 19:07:27jendriksetstatus: chatting -> resolved
messages:
  + msg5490


2016-08-05 12:11:03maltesetmessages:
  + msg5489


2016-08-04 21:45:44jendriksetmessages:
  + msg5488


2016-08-04 21:40:48maltesetstatus: unread -> chatting
messages:
  + msg5487


2016-08-04 21:34:13jendrikcreate