Issue674

Title CMake: automatically collect .h and .cc files
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To florian Keywords
Optional summary

Created on 2016-09-26.23:21:10 by jendrik, last changed by florian.

Messages
msg5919 (view) Author: florian Date: 2016-12-20.00:40:49
Merged, thanks.

The buildbot still has an unrelated problem on the mac but otherwise looks happy.
msg5918 (view) Author: malte Date: 2016-12-19.23:40:08
I had a quick look, looks good to merge!
msg5917 (view) Author: florian Date: 2016-12-19.23:00:10
Great. Malte, are you fine with us reviewing this, or should I put this into the
review queue?
msg5916 (view) Author: jendrik Date: 2016-12-19.22:22:13
Perfect. I have no objections to merging this.
msg5915 (view) Author: florian Date: 2016-12-19.22:15:21
Enabling pipelines didn't start them in the existing commits. I tried triggering
them manually but that didn't finish in reasonable time (no output or log or
anything like that). Locally running ./misc/run-all-tests works fine, though.
msg5913 (view) Author: jendrik Date: 2016-12-19.20:55:01
Looks good to me :-)

Do you want to enable the pipelines for this repo to see if all standard configs 
still run?
msg5912 (view) Author: florian Date: 2016-12-19.20:38:46
Here is a pull request for the updated CMake files and removing the empty files:
https://bitbucket.org/FlorianPommerening/downward-issues/pull-requests/28

Jendrik, can you have a look?
msg5665 (view) Author: jendrik Date: 2016-09-26.23:21:10
Quoting Malte's comment on a different issue 
(https://bitbucket.org/jendrikseipp/downward/pull-requests/58/issue535/diff#comment-24255752): 

"That would work, but I think it would be nicer to change the behaviour to the following (not necessarily now):

    1. Only specify the basename (without .cc or .h).
    2. If .cc exists, add it. If .h exists, add it. If neither exists, complain. 

This would make the "magic" a bit more consistent (.h and .cc would be treated equally, and planner.cc wouldn't 
need a special case), and we also wouldn't need to change the Makefile when we decide to add or remove a *.cc 
file.

Also, and perhaps more importantly, there are currently many cases where we have a *.h file and don't need it. 
This is mainly true for plug-ins (in the Fast Downward sense), which usually only depend on other things, but 
nothing depends on them."
History
Date User Action Args
2016-12-20 00:41:00floriansetstatus: reviewing -> resolved
2016-12-20 00:40:49floriansetmessages: + msg5919
2016-12-19 23:40:08maltesetmessages: + msg5918
2016-12-19 23:00:10floriansetmessages: + msg5917
2016-12-19 22:22:13jendriksetmessages: + msg5916
2016-12-19 22:15:21floriansetmessages: + msg5915
2016-12-19 20:55:01jendriksetmessages: + msg5913
2016-12-19 20:38:46floriansetstatus: unread -> reviewing
assignedto: florian
messages: + msg5912
2016-09-26 23:21:10jendrikcreate