Pull request looks good to me, but please do an experiment with all
configurations to make sure we caught all changes, that the new configurations
work as extended, and to see how the "fixed" portfolios differ in behaviour from
the old ones. (Conceivably, the "correct" configurations might perform worse in
which case we might want to change the portfolios.)
Due to the way the interaction between the parser, portfolios and iterated
searches work, I suggest to run all configurations based on portfolios for the
full 30 minutes. I'd be happiest if we also tested all other aliases, but here I
think I short timeout (e.g. 1 minute) is enough.
Once this is merged, please write an email to the Google group to let people
know about the changed option syntax.
|