Issue748

Title Replace GlobalOperator with OperatorProxy in search classes
Priority wish Status resolved
Superseder Nosy List florian, jendrik, malte
Assigned To florian Keywords
Optional summary
Part of issue509.

Once this is done, we could do issue700.

Created on 2017-11-27.23:28:04 by florian, last changed by florian.

Summary
Part of issue509.

Once this is done, we could do issue700.
Messages
msg6629 (view) Author: florian Date: 2017-11-29.09:38:57
Great! I merged and will get started on issue700 now.
msg6628 (view) Author: malte Date: 2017-11-29.09:20:58
Experimental data looks OK to merge.
msg6627 (view) Author: florian Date: 2017-11-29.08:24:17
The results look OK. There again were some errors on the grid: one task never
started; there were again 10 PSR tasks where VAL ran crashed; and I got a couple
of error messages complaining about a "Read-only file system". The last one
looks like it happens when slurm is cleaning up after the job, so it probably is
not an issue for the results.

Other than that, the expansions/evaluations/costs are unchanged, coverage and
timeouts/memory-outs only changed by a couple of tasks, and I cannot see a
specific trend on the runtime.

http://ai.cs.unibas.ch/_tmp_files/pommeren/issue748-v1-opt-issue748-base-issue748-v1-compare.html
http://ai.cs.unibas.ch/_tmp_files/pommeren/issue748-v1-sat-issue748-base-issue748-v1-compare.html

http://ai.cs.unibas.ch/_tmp_files/pommeren/issue748-v1-sat-total_time-ehc-ff-issue748-base-issue748-v1.png

I think this can be merged.
msg6626 (view) Author: florian Date: 2017-11-28.15:29:01
Now that issue747 is merged I updated lazy search as well. I can now run
experiments on this. I'd suggest the same configurations as in issue747 for lazy
search; LM-cut and blind search on the optimal benchmarks for eager search; and
ehc(ff()) for EHC.
msg6622 (view) Author: malte Date: 2017-11-28.00:13:57
Code looks reasonable, probably wants an experiment.
msg6620 (view) Author: florian Date: 2017-11-28.00:10:02
I started with this already and created a pull request:
https://bitbucket.org/FlorianPommerening/downward-issues/pull-requests/39/issue748/diff

The pull request doesn't touch LazySearch yet. I'll do the same change as in the
other searches there once issue747 is merged.
msg6617 (view) Author: florian Date: 2017-11-27.23:28:04
This should be simple once we merged issue474. This is the last place where
global operators occur outside of the global task, so afterwards we could
continue moving the global task into its own class in issue700.
History
Date User Action Args
2017-11-29 09:38:57floriansetstatus: chatting -> resolved
messages: + msg6629
2017-11-29 09:20:58maltesetmessages: + msg6628
2017-11-29 08:24:17floriansetmessages: + msg6627
2017-11-28 15:29:01floriansetmessages: + msg6626
summary: Part of issue509. Waiting for issue747. Once this is done, we could do issue700. -> Part of issue509. Once this is done, we could do issue700.
2017-11-28 00:13:57maltesetmessages: + msg6622
2017-11-28 00:10:02floriansetstatus: unread -> chatting
messages: + msg6620
2017-11-27 23:28:04floriancreate