Title convert Heuristic options to Evaluator
Priority feature Status resolved
Superseder Nosy List cedric, guillem, jendrik, malte, manuel, silvan
Assigned To manuel Keywords
Optional summary
This is part of issue727.

Created on 2018-03-16.15:37:43 by manuel, last changed by silvan.

This is part of issue727.
msg7384 (view) Author: silvan Date: 2018-09-12.11:12:38
msg7380 (view) Author: malte Date: 2018-09-11.18:46:28
Let's merge then! I'm not sure what this will do to the documentation, but we
will find out. :-) (I'm suscribed to all Doc changes on the wiki.)
msg7374 (view) Author: cedric Date: 2018-09-11.16:38:05
I tested seq-sat-lama-2011 on the blocksworld 8 problem and there was no
difference (except the times) in the output.
msg7371 (view) Author: malte Date: 2018-09-11.16:08:01
Code looks good. Without tests, I'm not sure I understand the subtle effects
this will have on the option parser and documentation, especially with the
LAMA-FF synergy.

Hence I suggest running a small local experiment with seq-sat-lama-2011,
before/after, on one task where LAMA finds multiple plans but eventually
terminates. For example, a blocksworld task that is large enough to require a
few seconds of search to finish the anytime search, but small enough for anytime
search to finish. Then check in meld what changes.

With other heuristics, I think this will either not break or break in a way that
we will find out automatically soon anyway, so no more tests necessary.

I don't fully understand what this will do with the documentation, but I think
if we merge issue749 soon, we will be fine.
msg7368 (view) Author: guillem Date: 2018-09-11.13:50:23
msg7367 (view) Author: malte Date: 2018-09-11.12:23:19
Access denied.
msg7364 (view) Author: guillem Date: 2018-09-11.12:06:23
We updated Manuel's original PR by merging the changes from default:

Looks ready to re-review and merge now
msg6981 (view) Author: jendrik Date: 2018-04-03.13:22:15
Manuel, do you want to add this to the review queue?
msg6914 (view) Author: jendrik Date: 2018-03-16.16:51:17
The code looks good to me.
msg6913 (view) Author: manuel Date: 2018-03-16.16:33:32
I added a pull request here .

I think we will rename the variable and function names in a later step of issue727.
msg6908 (view) Author: manuel Date: 2018-03-16.15:37:42
The options for setting heuristics for preferred operators or heuristics for
lama synergy are of type Heuristic. As we will change the option parser to allow
Evaluators only (issue718), we convert all Heuristic options to Evaluator.
Date User Action Args
2018-09-12 11:12:38silvansetstatus: reviewing -> resolved
nosy: + silvan
messages: + msg7384
2018-09-11 18:46:28maltesetmessages: + msg7380
2018-09-11 16:38:05cedricsetnosy: + cedric
messages: + msg7374
2018-09-11 16:08:01maltesetmessages: + msg7371
2018-09-11 13:50:23guillemsetmessages: + msg7368
2018-09-11 12:23:19maltesetmessages: + msg7367
2018-09-11 12:06:23guillemsetmessages: + msg7364
2018-04-03 13:22:25jendriksetstatus: in-progress -> reviewing
2018-04-03 13:22:15jendriksetmessages: + msg6981
2018-03-16 16:51:17jendriksetmessages: + msg6914
2018-03-16 16:33:32manuelsetmessages: + msg6913
2018-03-16 15:37:43manuelcreate