Issue824

Title Use TaskProxy in PerTaskInformation
Priority wish Status resolved
Superseder Nosy List cedric, florian, guillem, jendrik, malte
Assigned To florian Keywords
Optional summary

Created on 2018-09-17.13:21:23 by florian, last changed by florian.

Messages
msg7492 (view) Author: florian Date: 2018-09-17.15:44:31
Thanks. I merged and pushed the code.
msg7490 (view) Author: malte Date: 2018-09-17.15:33:32
I don't think so. If something significant goes wrong, run-all-tests should find it.
msg7489 (view) Author: florian Date: 2018-09-17.15:30:04
Thanks! I made the changes an updated the pull request again. Do we need
experiments for this?
msg7488 (view) Author: malte Date: 2018-09-17.15:23:53
I left some further comments on bitbucket.
msg7487 (view) Author: florian Date: 2018-09-17.15:14:04
Thanks! I handled them and updated the pull request.
msg7486 (view) Author: jendrik Date: 2018-09-17.15:06:24
I left some minor comments.
msg7482 (view) Author: florian Date: 2018-09-17.14:45:17
I created a pull request for this on Bitbucket:
https://bitbucket.org/FlorianPommerening/downward-issues/pull-requests/48
msg7479 (view) Author: malte Date: 2018-09-17.13:26:44
The rationale for TaskID (or whatever the name will be) is that we want to give
public access to an identify for a task proxy (for comparison, maps and
unordered_maps) without publicly exposing the internal AbstractTask *.
msg7478 (view) Author: florian Date: 2018-09-17.13:21:23
We decided to switch the PerTaskInformation introduced in issue774 to use
TaskProxy instead of AbstractTask* in its public interface. To make this
possible, we will give a get_id() method to TaskProxy that returns the pointer
wrapped in a class similar to StateID.
History
Date User Action Args
2018-09-17 15:44:31floriansetstatus: reviewing -> resolved
messages: + msg7492
2018-09-17 15:33:32maltesetmessages: + msg7490
2018-09-17 15:30:04floriansetmessages: + msg7489
2018-09-17 15:23:53maltesetmessages: + msg7488
2018-09-17 15:14:04floriansetmessages: + msg7487
2018-09-17 15:06:24jendriksetstatus: in-progress -> reviewing
messages: + msg7486
2018-09-17 14:45:17floriansetmessages: + msg7482
2018-09-17 14:02:32guillemsetnosy: + guillem
2018-09-17 13:36:42cedricsetnosy: + cedric
2018-09-17 13:26:44maltesetmessages: + msg7479
2018-09-17 13:21:23floriancreate