Issue826

Title Split option_parser.{h,cc} responsibilities
Priority feature Status resolved
Superseder Nosy List cedric, jendrik, malte, patfer
Assigned To patfer Keywords
Optional summary

Created on 2018-09-18.12:36:43 by patfer, last changed by patfer.

Messages
msg7557 (view) Author: patfer Date: 2018-09-19.10:13:15
Comments incorporated
msg7536 (view) Author: malte Date: 2018-09-18.18:53:08
Jendrik suggested I might also want to have a look.
Looks good! I'm done with my bitbucket comments.
msg7528 (view) Author: patfer Date: 2018-09-18.16:42:51
Review Changes incorporated
msg7526 (view) Author: jendrik Date: 2018-09-18.16:05:47
I'm done with my review.
msg7524 (view) Author: patfer Date: 2018-09-18.15:47:16
Code ready for reviewing
https://bitbucket.org/PatFer/downward/pull-requests/4/issue826/diff

We are still thinking if there exists a good way to split the OptionParser
further, but did not know one now.
msg7507 (view) Author: patfer Date: 2018-09-18.12:36:43
subissue of issue588

Include token_parser.h physically into option_parser.h

Split option_parser.{h, cc} by responsibilities.
History
Date User Action Args
2018-09-19 11:10:26patfersetstatus: reviewing -> resolved
2018-09-19 10:13:15patfersetmessages: + msg7557
2018-09-18 18:53:08maltesetmessages: + msg7536
2018-09-18 16:42:51patfersetmessages: + msg7528
2018-09-18 16:05:47jendriksetmessages: + msg7526
2018-09-18 15:47:16patfersetstatus: unread -> reviewing
messages: + msg7524
2018-09-18 13:33:20jendriksetnosy: + jendrik
2018-09-18 12:36:43patfercreate