Quoting Malte in msg7602: [Now that issue526 is merged, we can] remove the traces of the old
class Plugin from the code. I suggest doing this in the following steps, which in my opinion
can be done in the same issue, but I would do them in separate commits:
1. Remove code related to the class Plugin.
I think all this code should be in the option parser subdirectory.
It is not enough to search for "Plugin". Also look for overloads of functions
or templates that have a version for shared pointers and another one for
raw pointers. Searching for the word "shared" in the option parser should
probably find most or all relevant places: the code for raw pointers should
be right next to the code for shared pointers.
2. Optionally, clean up the method names etc. in the option parser that
previously included the word "shared" to distinguish them from the
raw pointer versions.
3. Rename the class PluginShared to Plugin. (This will touch lots of source
files, so should be a commit of its own.)
|